Bug 365343 - Use new IScriptResolver API during source lookup
Summary: Use new IScriptResolver API during source lookup
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.4 M5   Edit
Assignee: Michael Rennie CLA
QA Contact: Michael Rennie CLA
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 367806
  Show dependency tree
 
Reported: 2011-12-01 12:55 EST by Michael Rennie CLA
Modified: 2012-01-03 19:45 EST (History)
3 users (show)

See Also:

Attachments
fix (3.07 KB, patch)
2011-12-01 15:16 EST, Michael Rennie CLA 		no flags Details | Diff
better fix (3.95 KB, patch)
2011-12-01 15:45 EST, Michael Rennie CLA 		no flags Details | Diff
even better (4.88 KB, patch)
2011-12-05 13:31 EST, Michael Rennie CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2011-12-01 12:55:45 EST 
With the new API to help resolve remote <-> local scripts we can delegate finding local resources to contributors. This can greatly speed up source lookup. 

We should use the new API first and if no resolvers can return the local file(s) we can fall back to the 'old' way of finding source.
Comment 1 Michael Rennie CLA 2011-12-01 15:16:00 EST 
Created attachment 207809 [details]
fix

The patch adds a call into our source lookup scheme that consults script resolvers prior to trying to find the script source by search the source lookup path.
Comment 2 Michael Rennie CLA 2011-12-01 15:45:13 EST 
Created attachment 207810 [details]
better fix

Here is an updated fix for a CCE I was getting and adds support for script nodes as well.
Comment 3 Michael Rennie CLA 2011-12-05 13:31:34 EST 
Created attachment 207939 [details]
even better

This fix is event better as it has a fix for the NPE Hernan found (thanks Hernan).
Comment 4 Michael Rennie CLA 2011-12-19 11:31:33 EST 
The third patch has been applied to HEAD