Community
Participate
Working Groups
testModifyAndSaveBothSidesOfCompareEditorJava Failure Problems occurred when invoking code from plug-in: "org.eclipse.compare". junit.framework.AssertionFailedError: Problems occurred when invoking code from plug-in: "org.eclipse.compare". at org.eclipse.team.tests.ui.SaveableCompareEditorInputTest$TestLogListener.logging(SaveableCompareEditorInputTest.java:119) at org.eclipse.core.internal.runtime.RuntimeLog.logToListeners(RuntimeLog.java:160) at org.eclipse.core.internal.runtime.PlatformLogWriter.logged(PlatformLogWriter.java:100) at org.eclipse.equinox.log.internal.ExtendedLogReaderServiceFactory.safeLogged(ExtendedLogReaderServiceFactory.java:86) at org.eclipse.equinox.log.internal.ExtendedLogReaderServiceFactory.logPrivileged(ExtendedLogReaderServiceFactory.java:171) at org.eclipse.equinox.log.internal.ExtendedLogReaderServiceFactory.log(ExtendedLogReaderServiceFactory.java:150) at org.eclipse.equinox.log.internal.ExtendedLogServiceFactory.log(ExtendedLogServiceFactory.java:65) at org.eclipse.equinox.log.internal.ExtendedLogServiceImpl.log(ExtendedLogServiceImpl.java:87) at org.eclipse.equinox.log.internal.LoggerImpl.log(LoggerImpl.java:54) at org.eclipse.core.internal.runtime.PlatformLogWriter.logging(PlatformLogWriter.java:43) at org.eclipse.core.internal.runtime.RuntimeLog.log(RuntimeLog.java:96) at org.eclipse.core.runtime.SafeRunner.handleException(SafeRunner.java:71) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:48) at org.eclipse.compare.internal.ContentChangeNotifier$1.run(ContentChangeNotifier.java:65) at org.eclipse.compare.internal.ContentChangeNotifier.fireContentChanged(ContentChangeNotifier.java:79) at org.eclipse.compare.BufferedContent.fireContentChanged(BufferedContent.java:128) at org.eclipse.team.internal.ui.synchronize.LocalResourceTypedElement.fireContentChanged(LocalResourceTypedElement.java:298) at org.eclipse.team.internal.ui.synchronize.LocalResourceTypedElement$1.handleDocumentFlushed(LocalResourceTypedElement.java:149) at org.eclipse.team.internal.ui.synchronize.EditableSharedDocumentAdapter.flushDocument(EditableSharedDocumentAdapter.java:171) at org.eclipse.compare.contentmergeviewer.TextMergeViewer$ContributorInfo.flush(TextMergeViewer.java:978) at org.eclipse.compare.contentmergeviewer.TextMergeViewer.flush(TextMergeViewer.java:4889) at org.eclipse.compare.contentmergeviewer.TextMergeViewer.flushLeftSide(TextMergeViewer.java:4847) at org.eclipse.compare.contentmergeviewer.TextMergeViewer.flushContent(TextMergeViewer.java:4877) at org.eclipse.compare.contentmergeviewer.ContentMergeViewer.flush(ContentMergeViewer.java:1168) at org.eclipse.compare.CompareEditorInput.flushViewer(CompareEditorInput.java:1260) at org.eclipse.compare.CompareEditorInput.flushViewers(CompareEditorInput.java:1229) at org.eclipse.compare.CompareEditorInput.saveChanges(CompareEditorInput.java:1214) at org.eclipse.compare.internal.CompareEditor$5.execute(CompareEditor.java:542) at org.eclipse.ui.actions.WorkspaceModifyOperation$1.run(WorkspaceModifyOperation.java:106) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2344) at org.eclipse.ui.actions.WorkspaceModifyOperation.run(WorkspaceModifyOperation.java:118) at org.eclipse.compare.internal.CompareEditor.doSave(CompareEditor.java:550) at org.eclipse.team.tests.ui.SaveableCompareEditorInputTest.verifyModifyAndSaveBothSidesOfCompareEditor(SaveableCompareEditorInputTest.java:381) at org.eclipse.team.tests.ui.SaveableCompareEditorInputTest.testModifyAndSaveBothSidesOfCompareEditorJava(SaveableCompareEditorInputTest.java:415) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:501) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:259) at org.eclipse.test.UITestApplication$2.run(UITestApplication.java:197) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135) at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3563) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3212) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2701) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2665) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2499) at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:679) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:668) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:140) at org.eclipse.test.UITestApplication.run(UITestApplication.java:62) at org.eclipse.test.UITestApplication.start(UITestApplication.java:212) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:352) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:624) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:579) at org.eclipse.equinox.launcher.Main.run(Main.java:1433) at org.eclipse.equinox.launcher.Main.main(Main.java:1409) at org.eclipse.core.launcher.Main.main(Main.java:34)
This stack trace indicates that there was some error added to the log while the test was running. For me it seems that this error was not directly relevant to the test. Test passes locally and it also did not fail in any other builds. It seems that this was one-time problem.
This happens again consistently on all platforms.
And a combination of these fails too: testModifyAndSaveBothSidesOfCompareEditorProperties testModifyAndSaveBothSidesOfCompareEditorXml Maybe the test suite expects the tests to run in a particular order? In Java 7 the order is no longer fixed (i.e. no longer as the members appear in the class file). Hence, if the order is important use org.eclipse.test.OrderedTestSuite. Also note, that in the last arch call, we communicated that we want green tests again, so please resolve this for M5.
Those are errors that trigger the test to fail: > !ENTRY org.eclipse.ui 4 4 2013-01-29 10:57:51.990 > !MESSAGE Conflicting handlers for org.eclipse.ui.editors.lineNumberToggle: {ActionHandler(org.eclipse.ui.texteditor.AbstractDecoratedTextEditor$4@6a926a92)} vs {ActionHandler(org.eclipse.compare.internal.TextEditorPropertyAction@1ce11ce1)} > !ENTRY org.eclipse.ui 4 4 2013-01-29 10:57:52.021 > !MESSAGE Conflicting handlers for org.eclipse.ui.edit.text.toggleShowWhitespaceCharacters: {ActionHandler(org.eclipse.compare.internal.ShowWhitespaceAction@8f908f9)} vs {ActionHandler(org.eclipse.ui.texteditor.ShowWhitespaceCharactersAction@652b652b)} There are two conflicting actions that are contributed by compare and by AbstractDecoratedTextEditor. Only JavaMergeViewer has this conflict, because other viewers like TextMergeViewer do not call AbstractDecoratedTextEditor#createActions. The problem was there for a long time, but the conflicting actions where not detected, that was fixed recently with bug 378457. For M5 I can modify this test, so that it doesn't fail on problems like this and open another bug for conflicting actions, or we can use this bug for fixing the root cause problem, that I think should be fixed in JavaMergeViewer.
I'm looking at Bug 399396 PW
Fix for bug 399396 fixed the test, so I'm marking as duplicate. *** This bug has been marked as a duplicate of bug 399396 ***
(In reply to comment #6) > Fix for bug 399396 fixed the test, so I'm marking as duplicate. > > *** This bug has been marked as a duplicate of bug 399396 *** Depending on how we fix but 399457 It might still fail in 4.2.2 but in that case you can explain the failure in the bug where you give the go.
Still fails. http://download.eclipse.org/eclipse/downloads/drops4/S-4.3M5a-201302041400/testresults/html/org.eclipse.team.tests.core_linux.gtk.x86_6.0.html
(In reply to comment #8) > Still fails. > > http://download.eclipse.org/eclipse/downloads/drops4/S-4.3M5a-201302041400/ > testresults/html/org.eclipse.team.tests.core_linux.gtk.x86_6.0.html This test picks up every error in log thrown during comparing files. Each time it was reopened it discovered a different issue. This time I think it may be Bug 403827.
Marking this fixed again for the fix that was made in M5. The new failure is likely a different problem. If this fails again let's open a new bug.
