Community
Participate
Working Groups
org.eclipse.ui.tests.services.ILevelService is contributed through org.eclipse.ui.services, but they don't appear to line up with what we returned: The window level service locator returns an ILevelService that says "1" but it should be "2". org.eclipse.ui.tests.services.ContributedServiceTest.testWindowService()
Created attachment 208651 [details] start to fix the ServiceLocator v01 I think there needs to be a walk up the IEclipseContext after the getLocal(*) PW
Released http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c612044e0bb6e5ca9d93643f913a9a1e621b3b1f PW
(In reply to comment #2) > Released > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c612044e0bb6e5ca9d93643f913a9a1e621b3b1f Reopening as this comment caused keybindings to stop working. See bug 367849.
The keybinding problem has apparently been fixed. What's left to do here?
We're still not correctly using org.eclipse.ui.services. Any contribution will only get one service, instead of 1 per level. But we might have to push this to SR1 as even a simple change can break it. PW
This needs to be fixed, but any fix is extremely risky. Once this works, our own services (like commands) should be contributed the correct way as in 3.8. PW
(In reply to Paul Webster from comment #5) > We're still not correctly using org.eclipse.ui.services. Not sure what the issue is here, but it sounds to me that this must have been solved in the mentime. Marking as fixed, please reopen if need.
You mean we've started honouring org.eclipse.ui.services? Please test it out before you close the bug. PW
(In reply to Paul Webster from comment #8) > You mean we've started honouring org.eclipse.ui.services? Please test it > out before you close the bug. The description was a bit to fuzzy for me to test it. This bug sounds like a private note to yourself. And as keybinding work fine (mentioned here) in 4.4 work fine, I guessed you fixed the issue in the meantime. Can you describe the way how to test this issue and what the actual problem it?
You shouldn't close bugs especially if you can't reproduce the usecase that causes the problem. Use the org.eclipse.ui.services extension point. http://help.eclipse.org/kepler/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fextension-points%2Forg_eclipse_ui_services.html&cp=2_1_1_182 These tests fail: org.eclipse.ui.tests.services.ContributedServiceTest That's part of the reason the org.eclipse.ui.tests.services.ServicesTestSuite is commented out of the UI tests suites. The correct course of action is to fix it so all the tests pass, as it's a regression and indicates there is an entire piece of functionality that's broken. PW
(In reply to Paul Webster from comment #10) > You shouldn't close bugs especially if you can't reproduce the usecase that > causes the problem. > > Use the org.eclipse.ui.services extension point. > http://help.eclipse.org/kepler/index.jsp?topic=%2Forg.eclipse.platform.doc. > isv%2Freference%2Fextension-points%2Forg_eclipse_ui_services. > html&cp=2_1_1_182 > > These tests fail: org.eclipse.ui.tests.services.ContributedServiceTest > > That's part of the reason the > org.eclipse.ui.tests.services.ServicesTestSuite is commented out of the UI > tests suites. The correct course of action is to fix it so all the tests > pass, as it's a regression and indicates there is an entire piece of > functionality that's broken. Thanks for the clarification on the nature of this bug.
(In reply to Paul Webster from comment #10) > You shouldn't close bugs especially if you can't reproduce the usecase that > causes the problem. I think in general that is a valid reason to close a bug. But I agree with you that this should not be applied for bugs opened by another active committer.
(In reply to Lars Vogel from comment #12) > (In reply to Paul Webster from comment #10) > > You shouldn't close bugs especially if you can't reproduce the usecase that > > causes the problem. > > I think in general that is a valid reason to close a bug. But I agree with > you that this should not be applied for bugs opened by another active > committer. I mean by that you can't figure out the usecase to run to test the bug, then you can ask for clarification but you can't close the bug. If you run the usecase in the bug and you can't reproduce the problem, that's a valid reason to close the bug. PW
We seems to have survived 6 years without the 3.x mediator services creation. Please reopen if you plan to contribute patches.
