Community
Participate
Working Groups
Hi Kim, I just pushed a new tiny plugin project to JDT/Core's git: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/tree/org.eclipse.jdt.annotation This is supposed to be shipped together with the patch for bug 186342. That bug is currently in its end game, and if nothing bad is detected during the next few days we will want to include this like in Friday's warm-up build towards M4. Could you please coordinate with Satyam and Srikanth the necessary steps to include this bundle in the build as part of the jdt feature? Is it just adding entries to feature.xml and jdtcore.map? How must the entry to the map file be initialized to participate in automatic tagging? TIA
Was there some discussion already about what namespace to use for these annotations? It would be interesting to be able to use these annotations in the Platform but being in the JDT feature would prevent that. I suspect other potential consumers would also not like the apparent JDT dependency in their runtime code (even though it is a single project that could be consumed independently from the JDT feature). I wonder if they should be placed in a core or equinox namespace and put into the RCP feature.
(In reply to comment #1) > Was there some discussion already about what namespace to use for these > annotations? It would be interesting to be able to use these annotations in the > Platform but being in the JDT feature would prevent that. I suspect other > potential consumers would also not like the apparent JDT dependency in their > runtime code (even though it is a single project that could be consumed > independently from the JDT feature). I wonder if they should be placed in a > core or equinox namespace and put into the RCP feature. Good point, though I'm not sure why people would prefer "equinox" over "jdt" or the other way around unless they don't get any additional stuff besides the annotations.
> Good point, though I'm not sure why people would prefer "equinox" over "jdt" or > the other way around unless they don't get any additional stuff besides the > annotations. Also note that the annotations are Java specific i.e. they are not applicable for e.g. CDT developers. Hence a "jdt" or "java" should probably be in the name.
(In reply to comment #1) > Was there some discussion already about what namespace to use for these > annotations? Discussion was held within JDT, not with eclipse at large. > It would be interesting to be able to use these annotations in the > Platform glad to here that from you :) > but being in the JDT feature would prevent that. Why do you think so? The new bundle has no dependencies (except BREE-1.5) so what exactly should prevent platform components from compiling against this bundle? > I suspect other > potential consumers would also not like the apparent JDT dependency in their > runtime code Well, it's not strictly a runtime dependency. BTW: would this work? Import-Package: org.eclipse.jdt.annotation;resolution="optional" This could help the compiler and still allow to run any bundle referencing the annotations without having the annotations at runtime? > (even though it is a single project that could be consumed > independently from the JDT feature) my point exactly. > I wonder if they should be placed in a > core or equinox namespace and put into the RCP feature. Maybe from a build/packaging perspective there are good reasons for this but I think process is be much easier if JDT keeps ownership of this bundle.
John, I'd like to go with the proposed bundle / name space. Note that those who don't like the name can simply use their own annotations and configure JDT accordingly.
Ok, I buy the argument that since this is a source annotation that won't be retained at runtime, we should be able to use these annotations in our source without adding a JDT dependency in our bundles. So, the current name is ok with me.
Kim, is there anything else to do than adding it to the feature and the map file?
That should do it.
(In reply to comment #7) > Kim, is there anything else to do than adding it to the feature and the map > file? OK, then I can take care of this myself.
The feature and the map file have been updated.
(In reply to comment #10) > The feature and the map file have been updated. Thanks!
The jdt.annotation.source bundle is missing the license files. Please add them and update the build.properties. From N20111130-2000 Plugin directory missing required files: /buildtest/N20111130-2000/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.jdt.annotation.source_1.0.0.N20111130-2000.jar;
(In reply to comment #12) > The jdt.annotation.source bundle is missing the license files. Please add them > and update the build.properties. From N20111130-2000 Thanks, I've added the about.html to the source build. commit 476fcf718e0e7f9c1d93eac18e530f17ac58b00f
