Bug 36501 - [PropertiesView] Properties view not updated after selection change
Summary: [PropertiesView] Properties view not updated after selection change
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1.1   Edit
Assignee: Lynne Kues CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-15 09:51 EDT by Jörg Lewek CLA
Modified: 2003-06-02 16:53 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jörg Lewek CLA 2003-04-15 09:51:33 EDT
After a selection change in the package view the properties view is not 
updated - sometimes. We got this bug with other tree views in our own eclipse 
based application too.
We can reproduce the bug with the following procedure:

preferences:
workbench open mode = single click
number of opened editors before closing = 1

initial workbench state:
java perspective is opened
all editors are closed
packge view is visible
properties view is visible

first action:
select a java class in the package view
result: the editor is opened and the properties view is updated properly

second action:
select another java class in the same package
result: the editor content changes to the newly selected java class and the 
properties view is updated properly

third action:
select the first action java class again
result: the editor content changes to the newly selected java class and the 
properties view is still showing the properties of the second action java class
Comment 1 Simon Arsenault CLA 2003-05-02 13:48:32 EDT
Lynn, since you own the Properties view component, could you look into this. I 
kinda swamp right now as I'm handling Eduardo's components. If you do trace it 
down to something wrong with the selection service of the workbench, let me 
know and I'll try to help you out.
Comment 2 Lynne Kues CLA 2003-05-05 18:45:48 EDT
The given scenario also fails in the Resources Perspective when selecting 
regular text files.  So the problem is not specific to the Java Perspective or 
package viewer.  The problem is specific to the single click and reuse editors 
modes.
Comment 3 Lynne Kues CLA 2003-05-16 14:22:16 EDT
Tested this scenario in 2.0.1 and the bug does not exist.
Comment 4 Nick Edgar CLA 2003-05-16 14:53:45 EDT
Since this is a regression, please investigate a fix for 2.1.1.

When selecting the different items in the Package Explorer, does focus stay in 
the Package Explorer or does it switch to the editor?  If focus stays with the 
Package Explorer, then either the view is not communicating the selection 
change to the selection service, or the selection service is not properly 
communicating it to the Properties view.

Comment 5 Lynne Kues CLA 2003-05-19 17:28:17 EDT
problem is that the reset method of AbstractSelectionService is removing the 
PropertySheet's selection listener and it is never added back.  Need to talk to 
Simon about this.
Comment 6 Lynne Kues CLA 2003-05-22 12:08:06 EDT
Released fix into dev and 2.1.1 streams.