Bug 364142 - Update the doc with the regex filter in CVS syncs
Summary: Update the doc with the regex filter in CVS syncs
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.8 RC4   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
: 366167 (view as bug list)
Depends on: 352016
Blocks:
  Show dependency tree
 
Reported: 2011-11-18 07:30 EST by Tomasz Zarna CLA
Modified: 2012-06-06 06:54 EDT (History)
3 users (show)

See Also:
Szymon.Brandys: review+


Attachments
Updated doc (1.61 KB, patch)
2012-06-05 03:54 EDT, Malgorzata Janczarska CLA
no flags Details | Diff
Screenshot to update (20.20 KB, image/png)
2012-06-05 03:57 EDT, Malgorzata Janczarska CLA
no flags Details
Updated doc (1.66 KB, patch)
2012-06-06 06:17 EDT, Malgorzata Janczarska CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-11-18 07:30:41 EST
Bug 352016 added a new preference for filtering diffs. What's missing:
* the documentation for the new pref + updated screenshot
* the consider contents pref is now always honored, mentioned that in the doc as well
* adjust the pref wording if necessary
Comment 1 Dani Megert CLA 2011-12-09 07:13:03 EST
Tomek, when doing this please also fix a typo: it currently says:

"If performance is an issue this can be disabled to use the much faster time stamp based comparison"

but it's just the other way around: disabled -> enabled ;-)
Comment 2 Tomasz Zarna CLA 2011-12-12 07:11:35 EST
*** Bug 366167 has been marked as a duplicate of this bug. ***
Comment 3 Tomasz Zarna CLA 2011-12-12 07:12:03 EST
From bug 366167: 

The new 'Regular expression to ignore changes in synchronizations' preference is unclear to me. I have no clue what it actually does.

Also, it's not 100% clear what happens if the field is empty: does it fallback to time stamps? Maybe it would be clearer with a radio box, something along these lines:
( ) only use time stamps
( ) compare contents
( ) use diffs filtered by [   ]
Comment 4 Malgorzata Janczarska CLA 2012-06-05 03:54:27 EDT
Created attachment 216809 [details]
Updated doc
Comment 5 Malgorzata Janczarska CLA 2012-06-05 03:57:49 EDT
Created attachment 216811 [details]
Screenshot to update
Comment 6 Szymon Brandys CLA 2012-06-06 05:51:36 EDT
>> To ignore changes in synchronizations define a regular expression. If at lest one site of the change matches the defined regular expression the change will be ignored while comparing files based on the file contents.

You probably meant "If at least one side of the change".
Comment 7 Szymon Brandys CLA 2012-06-06 06:00:09 EDT
I would mention explicitely that "Only look at timestamps to detect changes" has to be disabled to use this new option. Maybe something liek this:

This option controls which changes should be ignored during content-based synchronizations i.e. when "Only look at timestamps to detect changes" is disabled. If at least one side of the change matches the defined regular expression, the change will be ignored.
Comment 8 Malgorzata Janczarska CLA 2012-06-06 06:17:18 EDT
Created attachment 216919 [details]
Updated doc
Comment 9 Szymon Brandys CLA 2012-06-06 06:54:09 EDT
Fixed with 0508c70eb05e9ad710a8b74af8618dcd91bd6877.