Bug 362368 - [Accessibility] Search form lacks role="button" and violates W3c guidelines
Summary: [Accessibility] Search form lacks role="button" and violates W3c guidelines
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: Steve Francisco CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2011-10-28 16:32 EDT by Neal Timpe CLA
Modified: 2011-11-16 10:38 EST (History)
4 users (show)

See Also:
ChrisAustin: review+

Attachments
use type="submit" for submit buttons in search form (3.32 KB, patch)
2011-11-11 15:07 EST, Steve Francisco CLA 		ChrisAustin: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neal Timpe CLA 2011-10-28 16:32:17 EDT 
Build Identifier: 3.1 and 3.6

The search bar lacks a role="button" label in its div.

It violates guideline 3.2b in W3c.  The violation on type="button". Is the button a submit button?  It is not defined in that way in the code.

Suggested fix: role="button" type="submit"


<form  name="searchForm"   onsubmit="doSearch()">
199 		 		 <table id="searchTable" align="left" valign="middle" cellspacing="0" cellpadding="0" border="0">
200 		 		 		 <tr nowrap  valign="middle">
201 		 		 		 		 <td  id="searchTD">
202 		 		 		 		 		 <label id="searchLabel" for="searchWord" accesskey="s">
203 		 		 		 		 		 &nbsp;<u STYLE="ACCELERATOR:true">S</u>earch
204 		 		 		 		 		 </label>
205 		 		 		 		 </td>
206 		 		 		 		 <td>
207 		 		 		 		 		 
<input type="text" id="searchWord" name="searchWord" value='' size="24" maxlength="256" alt='Search Expression' title='Search Expression'>
208 		 		 		 		 </td>
209 		 		 		 		 <td >
210 		 		 		 		 		 &nbsp;<input type="button" onclick="this.blur();doSearch()" value='GO' id="go" alt='GO' title='GO'>
211 		 		 		 		 		 <input type="hidden" name="maxHits" value="500" >
212 		 		 		 		 </td>

Reproducible: Always

Steps to Reproduce:
Steps to Reproduce:
1. Open an eclipse page
2. Use Firebug to focus on the code in the search bar.
Comment 2 Steve Francisco CLA 2011-11-11 15:07:33 EST 
Created attachment 206873 [details]
use type="submit" for submit buttons in search form
Comment 3 Steve Francisco CLA 2011-11-11 15:09:26 EST 
Chris, please review.  the change is to use type="submit" instead of type="button" to properly identify the purpose of the button according to the guidelines.
Comment 4 Chris Austin CLA 2011-11-16 10:38:18 EST 
Patch looks good.

Patch committed to master.