Bug 362365 - [Accessibility] Search table lacks role="presentation" tag and fails W3C accessibility guidelines
Summary: [Accessibility] Search table lacks role="presentation" tag and fails W3C acce...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.8 M4   Edit
Assignee: platform-ua-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2011-10-28 16:11 EDT by Neal Timpe CLA
Modified: 2011-11-29 12:01 EST (History)
4 users (show)

See Also:

Attachments
patch to add role=presentation to search panels (2.71 KB, patch)
2011-11-11 14:48 EST, Steve Francisco CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neal Timpe CLA 2011-10-28 16:11:50 EDT 
Build Identifier: 3.1 and 3.6

The table ID must include role="presentation" tag in a div to identify the headers. It violates guideline 1.3e. The violation occurs in the pop-up search and print tool in the TOC.

For a data table (i.e., the table tag does not contain a WAI-ARIA 'presentation' role), identify headers for the table rows and columns.

The test tool picked up the table tag and teh id="searchTable and flagged the violation. 

Violation flagged on line number 199

196 <body dir="ltr" onload="onloadHandler()"  onunload="closeAdvanced()">
197 
198 		 <form  name="searchForm"   onsubmit="doSearch()">
199 		 		 <table id="searchTable" align="left" valign="middle" 
cellspacing="0" cellpadding="0" border="0">
200 		 		 		 <tr nowrap  valign="middle">
201 		 		 		 		 <td  id="searchTD">
202 		 		 		 		 		 <label id="searchLabel" for="searchWord" accesskey="s">
203 		 		 		 		 		 &nbsp;<u STYLE="ACCELERATOR:true">S</u>earch
204 		 		 		 		 		 </label>

Reproducible: Always

Steps to Reproduce:
1. Open an eclipse page
2. Use Firebut to focus on the code in the TOC when the search and print table pops up.
Comment 2 Paul Webster CLA 2011-11-08 09:48:41 EST 
This is an Eclipse Foundation bug ... please provide a URL that resolves externally, internal IBM sites don't help the Foundation.

PW
Comment 3 Steve Francisco CLA 2011-11-11 14:48:20 EST 
Created attachment 206871 [details]
patch to add role=presentation to search panels
Comment 4 Steve Francisco CLA 2011-11-11 14:50:51 EST 
Chris could you review this change and commit?  the change is to add:
role="presentation"
to <table> elements for search panels so that accessibility readers can ignore the fact that there is a table around the search field.  ie, it's just for presentation purposes that a table was used, and the user wouldn't benefit from hearing "cell 1 contains "Search"" and "cell 2 contains a text field".
Comment 5 Steve Francisco CLA 2011-11-24 13:54:13 EST 
Comment on attachment 206871 [details]
patch to add role=presentation to search panels

this patch is obsolete. The patch on bug #362364 includes the changes needed for this fix.
Comment 6 Chris Austin CLA 2011-11-29 12:01:34 EST 
This has been fixed in Bug 362364.