Bug 361215 - Support products defined as mixture of bundles and features (type="mixed")
Summary: Support products defined as mixture of bundles and features (type="mixed")
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Tycho (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on: 361222
Blocks:
  Show dependency tree
 
Reported: 2011-10-18 04:21 EDT by Tobias Oberlies CLA
Modified: 2021-04-28 16:55 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Oberlies CLA 2011-10-18 04:21:18 EDT
p2 has been extended to support product definitions which specify their content as a list of bundles _and_ a list of features (bug 325622). These products have an attribute type="mixed". Currently, Tycho does not support building these features.
Comment 1 Tobias Oberlies CLA 2011-10-18 04:50:22 EDT
I found two places in Tycho which work on a product model:
org.eclipse.tycho.model.ProductConfiguration
org.eclipse.tycho.p2.impl.publisher.ProductDependenciesAction

The naive approach would be to extend these classes to use new attribute - but IMHO this doesn't scale: Instead of working on the low-level representation of the product file format, there should be simply methods which work on the semantical level, like a getContainedFeatures which returns null unless useFeatures="true" or type="mixed". For the latter, this requires a change to the p2 interface IProductDescriptor (see bug 361222)

The former (i.e. ProductConfiguration) needs to be modified (because it parses product files), but it should not expose the attribute. We should delete all syntactic methods (e.g. useFeatures) and only offer methods on the semantic level.
Comment 2 Tobias Oberlies CLA 2015-04-10 14:56:18 EDT
p2 documentation for type="mixed": https://wiki.eclipse.org/Equinox/p2/Publisher#ProductAction

(In reply to comment #1)
> I found two places in Tycho which work on a product model:
> org.eclipse.tycho.model.ProductConfiguration
> org.eclipse.tycho.p2.impl.publisher.ProductDependenciesAction
> 
> The naive approach would be to extend these classes to use new attribute
I suppose that this solution would be good enough.
Comment 3 Christoph Laeubrich CLA 2020-07-06 03:02:45 EDT
@Tobias I think we should first try to get support in the UI before enabling this for P2, sadly Bug 325614 was closed as WON'T FIX.
Without UI Support I think it will be very uncomfortable for users to actually use this feature and if PDE refuses to support this I think we should also close this as WON'T FIX (or investigated if there is any chance to get thi feature into PDE).
Comment 4 Christoph Laeubrich CLA 2020-11-23 13:42:13 EST
As no feedback on this it seems the feature is not of much interest, will close as WONTFIX for now.