Bug 360549 - AbstractCommentPart.createReadOnlyText hardcodes the task repository lookup
Summary: AbstractCommentPart.createReadOnlyText hardcodes the task repository lookup
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 0.8   Edit
Hardware: PC Linux
: P3 major with 1 vote (vote)
Target Milestone: 0.8.3   Edit
Assignee: Robert Munteanu CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 360547 360548 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-10-11 10:39 EDT by Robert Munteanu CLA
Modified: 2012-03-21 11:37 EDT (History)
0 users

See Also:

Attachments
mylyn/context/zip (1.11 KB, application/octet-stream)
2011-10-11 10:40 EDT, Robert Munteanu CLA 		no flags Details
Patch which uses the current review to extract the task repository (2.39 KB, patch)
2011-10-12 03:43 EDT, Robert Munteanu CLA 		no flags Details | Diff
mylyn/context/zip (deleted)
2011-10-12 03:44 EDT, Robert Munteanu CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Munteanu CLA 2011-10-11 10:39:50 EDT 
I've tried reusing the review UI support from Mylyn reviews for displaying comments. I've mapped the required parts ( ITopic, IComment etc ) for the comments, but the task repository lookup is limited to 'the first returned gerrit repository', which makes this not as useful for other task repositories.
Comment 1 Robert Munteanu CLA 2011-10-11 10:40:34 EDT 
Sorry about the duplicates, Mylyn was returning 'read timeout' errors and I resubmitted.
Comment 2 Robert Munteanu CLA 2011-10-11 10:40:35 EDT 
Created attachment 204954 [details]
mylyn/context/zip
Comment 3 Robert Munteanu CLA 2011-10-11 10:40:58 EDT 
*** Bug 360548 has been marked as a duplicate of this bug. ***
Comment 4 Robert Munteanu CLA 2011-10-11 10:41:16 EDT 
*** Bug 360547 has been marked as a duplicate of this bug. ***
Comment 5 Robert Munteanu CLA 2011-10-12 03:43:58 EDT 
Created attachment 204996 [details]
Patch which uses the current review to extract the task repository
Comment 6 Robert Munteanu CLA 2011-10-12 03:44:02 EDT 
Created attachment 204997 [details]
mylyn/context/zip
Comment 7 Robert Munteanu CLA 2011-10-12 03:45:48 EDT 
Comment on attachment 204997 [details]
mylyn/context/zip

Sorry, did not mean to upload this . Can anyone delete it?
Comment 8 Denis Roy CLA 2011-10-12 09:12:45 EDT 
The content of attachment 204997 [details] has been deleted by
    Denis Roy <denis.roy@eclipse.org>
who provided the following reason:

As requested by the submitter via webmaster inbox, 8:11am

The token used to delete this attachment was generated at 2011-10-12 09:12:25 EDT.
Comment 9 Steffen Pingel CLA 2011-10-12 15:43:59 EDT 
Thanks! I have applied the patch. In the future we should reconsider the current design and pass the reference to the task repository along with IFileItem to avoid the singleton dependency on the active review.
Comment 10 Steffen Pingel CLA 2011-10-13 17:04:36 EDT 
Reopening to backport change.
Comment 11 Steffen Pingel CLA 2011-10-13 17:31:48 EDT 
Fix backported to e_3_7_m_3_6_x branch.