Bug 360301 - [api] make provisional packages API
Summary: [api] make provisional packages API
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P2 enhancement (vote)
Target Milestone: 3.7   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords: api, noteworthy, plan
Depends on: 373165
Blocks: 350639
  Show dependency tree
 
Reported: 2011-10-08 01:34 EDT by Steffen Pingel CLA
Modified: 2013-03-04 04:02 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2011-10-08 01:34:03 EDT
Packages in o.e.m.commons.core and o.e.m.commons.ui have been provisional for several releases and should be converted into API packages.
Comment 1 Steffen Pingel CLA 2011-12-03 17:48:56 EST
Classes have been copied from internal provisional packages to API packages. The old classes have been deprecated but they are still included for backwards compatibility. We can consider keeping the deprecated classes for 3.7 but they are very likely to get removed prior to the 3.8 release.

As part of the move I created a new bundle org.eclipse.mylyn.commons.workbench. The split is based on dependencies: All classes with swt/jface dependencies only are in org.eclipse.mylyn.commons.ui, classes that depend on org.eclipse.ui.* are in org.eclipse.mylyn.commons.workbench. Integrators will need to add a requirement for org.eclipse.mylyn.commons.workbench where appropriate.

Some classes have slightly changed:

* Consumers of ScreenshotCreationPage now need to override getDialogSettings() to persist settings.
* AbstractNotificationPopup no longer shows the application icon. Consumers now need to extend AbstractWorkbenchNotificationPopup to retain the old behavior.
* EditorBusyIndicator was renamed to BusyAnimator and IBusyEditor was renamed to IBusyClient.

Usage of the following classes is now discouraged (see JavaDoc for further details):

* CommonColors
* CommonFonts
* CommonThemes
Comment 2 Steffen Pingel CLA 2011-12-03 18:30:37 EST
Changes are now in the repository.
Comment 3 Steffen Pingel CLA 2011-12-04 12:53:42 EST
Fixed an exception that was caused by a missing icon. Shawn, we should consider making the code more robust in case the images are not available.

!ENTRY org.eclipse.ui.workbench 4 0 2011-12-04 06:26:40.578
!MESSAGE Unable to create view ID org.eclipse.mylyn.tasks.ui.views.tasks: An unexpected exception was thrown.
!STACK 0
java.lang.NullPointerException
	at org.eclipse.mylyn.commons.workbench.search.TextSearchControl.createLabelButtonControl(TextSearchControl.java:247)
	at org.eclipse.mylyn.commons.workbench.search.TextSearchControl.<init>(TextSearchControl.java:158)
	at org.eclipse.mylyn.commons.workbench.EnhancedFilteredTree.doCreateFilterText(EnhancedFilteredTree.java:132)
	at org.eclipse.ui.dialogs.FilteredTree.createFilterText(FilteredTree.java:619)
	at org.eclipse.mylyn.commons.workbench.EnhancedFilteredTree.createFilterText(EnhancedFilteredTree.java:85)
	at org.eclipse.mylyn.commons.workbench.EnhancedFilteredTree.createFilterControls(EnhancedFilteredTree.java:67)
	at org.eclipse.mylyn.commons.workbench.AbstractFilteredTree.createFilterControls(AbstractFilteredTree.java:127)
	at org.eclipse.ui.dialogs.FilteredTree.createControl(FilteredTree.java:325)
	at org.eclipse.mylyn.commons.workbench.EnhancedFilteredTree.createControl(EnhancedFilteredTree.java:59)
	at org.eclipse.mylyn.commons.workbench.AbstractFilteredTree.createControl(AbstractFilteredTree.java:90)
	at org.eclipse.ui.dialogs.FilteredTree.init(FilteredTree.java:292)
	at org.eclipse.ui.dialogs.FilteredTree.<init>(FilteredTree.java:216)
	at org.eclipse.mylyn.commons.workbench.EnhancedFilteredTree.<init>(EnhancedFilteredTree.java:46)
	at org.eclipse.mylyn.commons.workbench.AbstractFilteredTree.<init>(AbstractFilteredTree.java:69)
	at org.eclipse.mylyn.internal.tasks.ui.views.TaskListFilteredTree.<init>(TaskListFilteredTree.java:128)
	at org.eclipse.mylyn.internal.tasks.ui.views.TaskListView.createPartControl(TaskListView.java:809)
	at org.eclipse.ui.internal.ViewReference.createPartHelper(ViewReference.java:375)
Comment 4 Steffen Pingel CLA 2013-03-04 04:02:04 EST
*** Bug 402264 has been marked as a duplicate of this bug. ***