Bug 358092 - Next Editor modeless dialog now responds to Mouse Over, (and it shouldn't)
Summary: Next Editor modeless dialog now responds to Mouse Over, (and it shouldn't)
Status: CLOSED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7.2   Edit
Hardware: PC Windows 7
: P3 normal with 3 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2011-09-19 06:54 EDT by David Woldrich CLA
Modified: 2016-07-19 07:24 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Woldrich CLA 2011-09-19 06:54:45 EDT
Build Identifier: 20110615-0604

The "Editors" modeless dialog that appears when the "Next Editor" command fires now responds to mouse-over events when my mouse moves and is over any of the entries in the editors window list.  The effect of this is that the selection can change to what the mouse is over and the mouse moves.  I believe this is incorrect semantics as it interferes with successful keyboard keying through the window list if the mouse happens move even slightly while that Editors dialog is up.

This Editors dialog does respond to mouse-click, and that behavior does strike me as correct.  In other words, while this dialog is up, I should be able to mouse click to select and dismiss the dialog, regardless of what keys on the keyboard are down.  But the selection should only change to the clicked item on click and not otherwise.  So, I contend that the mouse-over is the only really incorrect thing happening here.

I believe this behavior is new in Indigo.  

Here is another odd behavior I'm seeing in Indigo, and I'm not sure it's related or not to the bug stated above.  I like to assign new keybindings to Next Editor and Previous Editor:  Microsoft's old school "cool keys", Ctrl+Tab and Ctrl+Shift+Tab.  

Ctrl+Tab works fine with Next Editor, but Previous Editor does not seem to function at all with a Ctrl+Shift+Tab binding (and it does function as expected with the default binding, Ctrl+Shift+F6.)  I suspect there may have been some refactorings done to this code in Indigo that are neglecting to respect the user's key binding customizations for Previous Editor.

Otherwise, cheers to you for keeping good semantics around Next Editor and Previous Editor commands - Eclipse is one of the only IDE's left that does editor stacking the right way.

Reproducible: Always

Steps to Reproduce:
1. Open multiple files as editors in your workspace
2. (Assuming your Next Window bindings are Ctrl+F6) Hold Ctrl down and hit F6, the Editors dialog should appear floating over your editor
3. Continue to hold ctrl and hit F6 a couple more times, the selection should change.
4. Continue to hold ctrl and float the mouse over the Editors file list, the selection should change to the list item that the mouse is floating over (incorrect, unexpected!)
Comment 1 Remy Suen CLA 2011-09-19 08:19:53 EDT
I20110809-0800 (3.8.x): Reproducible.
I20110906-2000 (4.2.x): Cannot reproduce.

Though that's not to say that 4.x isn't broken, something may be missing in our implementation of the org.eclipse.ui.workbench bundle.
Comment 2 Paul Webster CLA 2011-09-23 15:19:33 EDT
(In reply to comment #1)
> I20110809-0800 (3.8.x): Reproducible.

Should check 3.6 .. I thought it always worked this way.

PW
Comment 3 Remy Suen CLA 2011-09-23 16:14:49 EDT
(In reply to comment #2)
> Should check 3.6 .. I thought it always worked this way.

Sorry, should've stated it in comment 1. 3.6 doesn't have this behaviour on Windows XP.
Comment 4 David Woldrich CLA 2011-09-23 16:51:30 EDT
(In reply to comment #3)
> (In reply to comment #2)
> > Should check 3.6 .. I thought it always worked this way.
> 
> Sorry, should've stated it in comment 1. 3.6 doesn't have this behaviour on
> Windows XP.

I also cannot reproduce the Mouse Over behavior on Windows XP with Eclipse Helios Service Release 2, build id: 20110301-1815.  Also, a ctrl+shift+tab binding for Previous Editor works in the Helios build.

To restate for clarity, Eclipse Helios works properly (in my opinion), and Eclipse Indigo shows the new behaviors/bugs.

Thanks for looking at my bug!
Comment 5 Andreas Bjerkeholt CLA 2013-04-05 09:00:21 EDT
Maybe this bug needs to broken up into multiple ones, since it contains different issues, but the first problem mentioned (which is also the title), is a great annoyance, and I would love to see this fixed.

You may compare the behaviour to the alt-tab functionality in Win7, where it works much better and moving the mouse over any item does not change the item selected by key presses.
Comment 6 Ihate Eclipse CLA 2016-07-07 06:54:14 EDT
Is this bug ever going to be addressed? This kind of bugs make web sites like http://www.ihateeclipse.com/ flourish. It is extremely annoying and for any Eclipse programmer should be a matter of minutes to fix it.
Comment 7 Patrik Suzzi CLA 2016-07-19 07:23:40 EDT
(In reply to Ihate Eclipse from comment #6)
> Is this bug ever going to be addressed? This kind of bugs make web sites
> like http://www.ihateeclipse.com/ flourish. It is extremely annoying and for
> any Eclipse programmer should be a matter of minutes to fix it.

This bug is fixed. I cannot reproduce in Eclipse Neon. 

See: http://i.imgur.com/gtgUF0I.gifv

Please, re-open if you can reproduce it and provide steps to reproduce. 

Thanks for help making Eclipse better ;)