Community
Participate
Working Groups
20030324 Linux-GTK In some cases, 'Synchronize CVS projects' synchronizes only the projects of a working set instead of all projects. 1. In a workspace with at least 2 CVS projects, change a file in one project. 2. Click on the 'Synchronize CVS projects' button. 3. On the dialog, select 'Include working set resources shared with CVS:', add click 'Other...'. 4. Create a new working set which contains only the project with no changes. Select this working set, click 'OK'. 5. Click 'OK'. The dialog 'Workspace resources are the same as remote' is displayed. 6. Click on the 'Synchronize CVS projects' button. 7. Select 'Include all projects shared with CVS'. 8. Click 'OK'. The changes are displayed. 9. Click on the 'Synchronize CVS projects' button. 10. Click 'OK'. The dialog 'Workspace resources are the same as remote' is displayed. It should display the change, as in the last synchronize request, 'Include all projects shared with CVS' was selected. It look's like it synchronizes only the projects of the working set.
This works for me on Windows. Perhaps it is particulr to GTK.
I confirm that I cannot reproduce the problem on Windows. I think is the same (type of) problem as in bug 29887 and bug 32078. On GTK, when the drop-down list is filled, a 'selection changed' event is generated. I guess that when the event occurs, you set some internal parameters to do the synchronize only on the projects of the 'selected' working directory. I see two fixes. You can move the addSelectionListener() call after the code which populates the list. Or you change the selectionChanged() method, so you take care of the events only if 'Include working set resources shared with CVS:' is selected.
I'm sure you are correct about the selection listener. The fix is easy but unfortunately, it's too late to make it into 2.1:-(
Based on the comments form Veronica in bug 29887, is it true that will have to ensure that *every* seletion listener in Eclipse be changed to be GTK friendly (e.g. added after widget is populated)?
Adding VI. VI and SN need to revisit the "GTK combo box event different behavior" issue again, even though we think it's the correct platform behavior, because people keep hitting the difference. If there is something simple and correct that SWT can do to work around this, we should do it.
Actually, Jean-Michel, in most cases the application wants to know about a selection and should add the selction listener before adding items to the combo list. CVS seems to be unique here in that despite that the fact that the combo box shows a selected item, you wish to ignore it. To correctly support GTK, I think we would need to ensure that the selection listener was added before adding the items in all cases in eclipse except special cases like yours.
This should be fixed for 2.1.1
Created attachment 4721 [details] Reposition combo box selection listener A patch to move the combo box selection listener for the mruList after the point at which the mruList is initialized. Tested bothe the scenerio in the bug and working set rename. Tested on RedHat GTK.
Released to HEAD will be released to 2.1.1 tomorrow
Verified in 2.1.1 Maintencance build and 3.0 HEAD build
Verified.
