Description Denis Zvonov 2003-03-25 09:57:46 EST

Two problems


1. It returns incomplete list of classes. See my comment in the code.


/**


 * Returns the class search order starting with <code>extensibleClass</code>.


 * The search order is defined in this class' comment.


 */


private List computeCombinedOrder(Class inputClass) {


	List result = new ArrayList(4);


	Class clazz = inputClass;


	while (clazz != null) {


		// add the class


		result.add(clazz);


		// add all the interfaces it implements


		Class [] interfaces = clazz.getInterfaces();


		for (int i=0; i<interfaces.length; i++) {


/***********************************


>> Denis:


HERE WE NEED TO GET ALL SUPERINTERFACES FOR INTERFACES AND SUPERINTERFACES FOR 
THEM etc. AND PLACE THEM INTO result.


*************************************/


			result.add(interfaces[i]);


		}


		// get the superclass


		clazz = clazz.getSuperclass();


	}


	return result;


}




2. private Class getCommonClass(List objects) works wrong.




Suppose we have 3 objects. First and Second has common class IProjectNature, 
while all three First, Second and Third has IAdaptable in their inheritance 
chains.


First this method searches for common for First and Second. It finds 
IProjectNature. Then it starts looking for common in IProjectNature and Third 
and finds nothing! Actually it is expected to find IAdaptable as the base for 
this three objects.


Then, more complex cases when all objects has not one but several common classes 
in their inheritance chains. You see First and Second has both IProjectNature 
and IAdaptable in common, so Object Contributors for both interfaces should 
apply.