Community
Participate
Working Groups
Created attachment 202074 [details] Screenshot +++ This bug was initially created as a clone of Bug #353503 +++ R3_7_maintenance With the last change from bug 353503, the textWidget.computeTrim(0, 0, 0, 0) in SourceViewer.RulerLayout#layout() now returns a fake trim with width and height of 15 (which is too big, see bug 353503 comment 19). The fake trim leads to a wrong height for the vertical ruler, since we reserve the space for the scroll bar. We still need a way to find out whether the scrollbar is always there or whether it's an overlay.
Yes, I agree we need to add API to determine whether the scrollbars are overlay or not. Client code will have to change to use the new API. The released code makes 3.7.1 functional. We will work on the new API only for 3.8.
Overlay scrollbars are available on GTK as well (latest Ubuntu). The current implementation of SWT is to fake the trim their as well.
Ping. Users are unhappy with the gray box in the line number ruler (bug 363482).
This API should be added in M6. We will maybe want to support NSScrollView's setScrollerStyle in the future, so the getter API could be "public boolean getShowOverlayScrollBars()" in Scrollable.
Lakshmi, please work on this for M6. I would say the API should be: public boolean Scrollable.getOverlayBars();
Created attachment 210779 [details] patch Patch adds the API for cocoa and stubs for windows & gtk. A comment about the name: I wonder if getOverlayBars() could be misleading to return Scrollbar as it sounds similar to Scrollable.getVerticalBar() and getHorizontalBar() which returns ScrollBar. May be we could use getShowOverlayBars or getUseOverlayBars?
I checked eclipse on Ubuntu 11.04 and it doesn't show the overlay scrollbars though the required library has been installed. Looks like eclipse is in the blacklist for overlay bars. So, we have to check eclipse on the latest Ubuntu to see if the overlay scrollbars and the graybox problem appear there.
(In reply to comment #6) > Created attachment 210779 [details] > patch > > Patch adds the API for cocoa and stubs for windows & gtk. > > A comment about the name: I wonder if getOverlayBars() could be misleading to > return Scrollbar as it sounds similar to Scrollable.getVerticalBar() and > getHorizontalBar() which returns ScrollBar. May be we could use > getShowOverlayBars or getUseOverlayBars? Yes, I also think it is misleading, but I do not like the other options either. I believe we should add a more "generic" API in Scrollable so that we have room to extend it in the future. How about: public int getScrollbarsMode() And for now, we add this constant in SWT: public static final int OVERLAY_BAR = 1 << 1; I could see other constants added later on to solve bug#363441 (ie. DARK_BAR, LIGHT_BAR). Note that the patch is not calling checkWidget().
(In reply to comment #7) > I checked eclipse on Ubuntu 11.04 and it doesn't show the overlay scrollbars > though the required library has been installed. Looks like eclipse is in the > blacklist for overlay bars. So, we have to check eclipse on the latest Ubuntu > to see if the overlay scrollbars and the graybox problem appear there. The eclipse executable is blacklisted, but if you just rename it (branding), the overlay scrollbars show up. They also show up for eclipse if the launcher cannot embedded the VM and has to launch java as a separate process. I am not sure how we could determine if the scrollbars are overlay or not. We could check the env var LIBOVERLAY_SCROLLBAR, but overlay-scrollbar package may not even be installed.
(In reply to comment #8) getScrollbarsMode() sounds good, but SWT.OVERLAY_BAR, DARK_BAR, LIGHT_BAR would deviate from the common naming pattern <CATEGORY>_<INSTANCE>. BAR_OVERLAY or SCROLLBAR_OVERLAY would be better names.
Created attachment 211335 [details] patch-2 Sorry, I had made the changes sometime back, but forgot to attach the patch here. Modified the API to public int getScrollbarsMode().
(In reply to comment #9) > (In reply to comment #7) > > I checked eclipse on Ubuntu 11.04 and it doesn't show the overlay scrollbars > > though the required library has been installed. Looks like eclipse is in the > > blacklist for overlay bars. So, we have to check eclipse on the latest Ubuntu > > to see if the overlay scrollbars and the graybox problem appear there. > > The eclipse executable is blacklisted, but if you just rename it (branding), > the overlay scrollbars show up. They also show up for eclipse if the launcher > cannot embedded the VM and has to launch java as a separate process. > > I am not sure how we could determine if the scrollbars are overlay or not. We > could check the env var LIBOVERLAY_SCROLLBAR, but overlay-scrollbar package may > not even be installed. Thanks Silenio, renaming and launching eclipse shows the overlay bars. And the graybox problem appears in the editor. I checked but I couldn't find any API support to detect overlay bars. Also, looks like the environment variable LIBOVERLAY_SCROLLBAR is not set when the overlay bar is enabled by default.
(In reply to comment #12) > I checked but I couldn't find any API support to detect overlay bars. Also, > looks like the environment variable LIBOVERLAY_SCROLLBAR is not set when the > overlay bar is enabled by default. Thats right, there is no environment variable to indicate whether overlay scrollbars are being used. I think the variable was only used earlier to explicitly enable the overlays when they weren't used by default.
There are some bad imports in Scrollable.java win32, otherwise patch is good to release.
Thanks Silenio! Fixed in master --> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=67d2c3a2030f152815bf563d9ce1b6fb14017009 I'll open a separate bug to track this on gtk.
> I'll open a separate bug to track this on gtk. Opened Bug 372480 to track this.
