Bug 35533 - [DND] remove dropContribution element from dropAction extension point schema
Summary: [DND] remove dropContribution element from dropAction extension point schema
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 RC4   Edit
Assignee: Knut Radloff CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-21 21:42 EST by Yu-Fen Kuo CLA
Modified: 2003-03-27 10:20 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yu-Fen Kuo CLA 2003-03-21 21:42:42 EST 
In the Platform Plugin-Developer Guide->Reference->Workbench-
>org.eclipse.ui.dropActions documentation

The dropContribution element is missing in "Examples" section of a drop action 
extension.
If readers try to use the example in plugin.xml will get 
message "Element 'action' is not legal as child of element 'null'
Comment 1 Knut Radloff CLA 2003-03-26 15:28:39 EST 
I updated the dropActions schema example.
However, when I also fix the readme example plugin.xml, the extension point no 
longer works.
E.g., this does not work
<extension
    point="org.eclipse.ui.dropActions">
    <dropContribution>
        <action                     
             class="org.eclipse.ui.examples.readmetool.ReadmeDropActionDelegate"
             id="org_eclipse_ui_examples_readmetool_drop_actions">
        </action>
    </dropContribution>
</extension>

Nick, do you know what's going on here?
Comment 2 Nick Edgar CLA 2003-03-26 15:55:37 EST 
Looks like the code in PluginDropAdapter ignores the name of the element.
For 2.1, should just make the schema conform to current practice: 
- <action> elements are direct children of the extension
- no <dropContribution> element
Comment 3 Nick Edgar CLA 2003-03-26 15:56:53 EST 
The error message mentioned above must have been a "compilation" problem 
generated by the PDE schema checker.  The Readme example would have failed the 
check as well.
Comment 4 Knut Radloff CLA 2003-03-26 18:31:49 EST 
The weird thing is I don't get an error when I don't specify the 
<dropContribution> element in the readme example. Sounds like a bug to me. I'll 
change the schema to get rid of <dropContribution>.
Comment 5 Knut Radloff CLA 2003-03-26 18:33:30 EST 
Is the schema change considered a code change? Or can I just go and release it?
Comment 6 Nick Edgar CLA 2003-03-26 22:47:19 EST 
You can go ahead and release it.  The schema files are equivalent to doc and 
Javadoc.

Dejan, any idea why we wouldn't get a compilation warning for this?
I have v1.2 of org.eclipse.ui/schema/dropActions.exsd loaded, and the latest 
org.eclipse.ui.examples.readmetool.
Comment 7 Knut Radloff CLA 2003-03-27 10:20:41 EST 
Release fixed dropActions schema. Entered bug 35758 for lack of PDE error 
feedback.