Bug 355258 - The compiler preferences need to be updated to allow the configuration of options
Summary: The compiler preferences need to be updated to allow the configuration of opt...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Tony Chen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 355538 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-08-19 15:07 EDT by Joseph Vincens CLA
Modified: 2017-02-23 14:19 EST (History)
6 users (show)

See Also:


Attachments
Patch for generation arguments (24.67 KB, patch)
2011-09-05 05:26 EDT, Tony Chen CLA
lasher: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Vincens CLA 2011-08-19 15:07:27 EDT
We need a generalized way of assigning and passing options to compilers and generators.

We currently have a generation option 'report' and no way to enable it. When present it generates an HTML file for each generated file. This html shows what template generated each piece of code. 

1 suggestion was to create a simple text box like the eclipse launch configuration's Arguments tab Program arguments and VM arguments text boxes, except for EDT the compiler has options and each generator would have it's own options. 

Talk to Jeff about how the options are used with the compiler and generators.
Comment 1 Tony Chen CLA 2011-09-01 05:06:03 EDT
*** Bug 355538 has been marked as a duplicate of this bug. ***
Comment 2 Tony Chen CLA 2011-09-01 05:31:27 EDT
Looking at the compiler preference. Need to refine the code a bit so a new parameter (generatorArgument) can be added.
Comment 3 Tony Chen CLA 2011-09-05 05:26:38 EDT
Created attachment 202741 [details]
Patch for generation arguments

Patch for generation arguments
Comment 4 Tony Chen CLA 2011-09-05 05:34:39 EDT
Joe, Jeff, attached is a patch for the proposed changes to support generation arguments, please review it. 

Major changes:
- Added a text field in generator setting tab to allow user input "Generation arguments". This field is only available in project and resource scope. (you can not set generation argument across workspace)
- Generation argument will be saved to preference (like we did for generation directory)
- add convenient method getGenerationArgument(IResource resource) in AbstractGenerator to fetch the save argument

Questions: 
- Do we need to set default generation argument for the workspace?
- Is is ok to allow any string to be input? Is any format check necessary?
Comment 5 Matt Heitz CLA 2011-09-06 10:11:07 EDT
In this release, the preferences page should allow any input string and not do any format checking.  The generators should throw an exception if they see something they don't like.

In the future we should have a better way to set generator arguments (something that provides more guidance than a simple text field).  It should include validation.
Comment 6 Tony Chen CLA 2011-09-15 02:19:07 EDT
Completed
Comment 7 Joseph Vincens CLA 2011-09-15 08:36:14 EDT
verified