Description Carlos 2011-08-16 12:19:42 EDT

Build Identifier: 20110218-0911

MemoryRenderingElements created by the MemorySegmentLabelAdapter class will somtimes be giving incorrect cell address values. The issue occurs when the addressable size of memory is greater than one byte, and when the table in a memory view contains more than one column. 

The exact problem can be traced to the following method:

	private MemoryRenderingElement getMemoryRenderingElement(MemorySegment line, BigInteger lineAddress, int offset, AbstractBaseTableRendering rendering) {
		BigInteger cellAddress = lineAddress.add(BigInteger.valueOf(offset));
		MemoryByte[] bytes = line.getBytes(offset, rendering.getBytesPerColumn());
		// make a copy to ensure that the memory bytes are not overwritten
		// by clients
		MemoryByte[] copy = new MemoryByte[bytes.length];
		System.arraycopy(bytes, 0, copy, 0, bytes.length);
		MemoryRenderingElement renderingElement = new MemoryRenderingElement(
				rendering, cellAddress, copy);
		return renderingElement;
	}

the problem actually occurs in the first line of the method:

BigInteger cellAddress = lineAddress.add(BigInteger.valueOf(offset));

To fix this issue, the offset needs to be divided by the addressable size:

BigInteger cellAddress = lineAddress.add(BigInteger.valueOf(offset/redering.getAddressableSize()));



Reproducible: Always

Steps to Reproduce:
1.Create a memory block that has an addressable size of greater than one byte

2.open a memory view and format the view to have multiple columns per row

3.add a color adaptor to the memory block and check the address values of MemoryRenderingElements that are passed to either getForeground() or getBackground().