Bug 354244 - Role-side callin guard predicate interferes with Team.isExecutingCallin()
Summary: Role-side callin guard predicate interferes with Team.isExecutingCallin()
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTJ (show other bugs)
Version: 2.0   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard: Also released in 2.1 M1
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-09 09:06 EDT by Stephan Herrmann CLA
Modified: 2017-08-02 10:28 EDT (History)
1 user (show)

See Also:

Attachments
test & fix (7.82 KB, patch)
2011-08-09 09:16 EDT, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2011-08-09 09:06:42 EDT 
I have observed that the reflective function Team.isExecutingCallin() 
will constantly answer 'true' after some point. It turned out that
this happened after a role-side callin guard predicate of the same
team instance has evaluated to 'false'.
Comment 1 Stephan Herrmann CLA 2011-08-09 09:16:57 EDT 
Created attachment 201140 [details]
test & fix

Analysis showed that the exception handler by which the isExecuting
flag is reset had too short a range.

The patch fixes this by putting more generated statements inside
the generated try block instead of the top-level list of statements.
Comment 2 Stephan Herrmann CLA 2011-08-09 09:18:24 EDT 
Released for 2.0.1 as r1822/23.
Comment 3 Stephan Herrmann CLA 2011-08-17 15:27:27 EDT 
Verified for 2.0.1 using build 201108160141.
Comment 4 Lars Schuetze CLA 2017-08-02 09:33:06 EDT 
This bug happens again. Needs to be reopened.
Comment 5 Stephan Herrmann CLA 2017-08-02 09:45:20 EDT 
(In reply to Lars Schuetze from comment #4)
> This bug happens again. Needs to be reopened.

Can you provide steps to reproduce?
Comment 6 Lars Schuetze CLA 2017-08-02 09:47:05 EDT 
It fails in hudson https://hudson.eclipse.org/objectteams/job/buildAndTest/158/#showFailuresLink and also on my local machine. Just execute the current test cases out of the master branch.

org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22 - 1.5
org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22 - 1.6
org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22 - 1.7
org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22 - 1.8
Comment 7 Stephan Herrmann CLA 2017-08-02 10:28:21 EDT 
(In reply to Lars Schuetze from comment #6)
> It fails in hudson
> https://hudson.eclipse.org/objectteams/job/buildAndTest/158/#showFailuresLink
> and also on my local machine. Just execute the current test cases out of the
> master branch.
> 
> org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22
> - 1.5
> org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22
> - 1.6
> org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22
> - 1.7
> org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22
> - 1.8

Ah, thanks for reminding me. We already have bug 469768 for that...

And the full list of failures is handled via bug 484164.