Bug 353903 - "Function Callgraph" should use the most recently used launch config
Summary: "Function Callgraph" should use the most recently used launch config
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: Call Graph (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.9.0   Edit
Assignee: Roland Grunberg CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-04 11:13 EDT by Roland Grunberg CLA
Modified: 2011-09-19 10:42 EDT (History)
4 users (show)

See Also:

Attachments
Patch (350.85 KB, patch)
2011-08-31 14:01 EDT, Roland Grunberg CLA 		no flags Details | Diff
Patch (2.21 KB, patch)
2011-08-31 14:06 EDT, Roland Grunberg CLA 		no flags Details | Diff
Fill default configuration with the same attributes that are used by LaunchStapGraph (12.73 KB, patch)
2011-09-05 16:44 EDT, Otavio Pontes CLA 		rgrunber: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Grunberg CLA 2011-08-04 11:13:42 EDT 
(See http://dev.eclipse.org/mhonarc/lists/linuxtools-dev/msg01153.html for more details)

Currently when going to Profile As -> Function Callgraph the behaviour is to have the default launch configuration used in profiling a binary. It might make more sense to use the most recently used launch configuration.
Comment 1 Roland Grunberg CLA 2011-08-11 09:32:00 EDT 
On a related note, commit d51321e fixes the issue of creating many different launch configurations.
Comment 2 Roland Grunberg CLA 2011-08-23 10:46:17 EDT 
The fix for now is to always profile with the default, and not generate any new launch configurations. Users always have the option to create their own from the menu.
Comment 3 Otavio Pontes CLA 2011-08-23 13:27:17 EDT 
This idea is good. But now I have another problem. Before this patch I could run using callgraph and than change some configuration. Now I need to add a new configuration an fill all items with the values I want. What about filling the form with default values when creating a new configuration?
Comment 4 Roland Grunberg CLA 2011-08-31 14:01:24 EDT 
Created attachment 202552 [details]
Patch

This should generate the default launch configuration. Let me know if this is the desired behaviour.
Comment 5 Roland Grunberg CLA 2011-08-31 14:06:37 EDT 
Created attachment 202553 [details]
Patch

Correct patch.
Comment 6 Roland Grunberg CLA 2011-08-31 14:44:18 EDT 
Re-open bug.
Comment 7 Otavio Pontes CLA 2011-09-05 16:44:39 EDT 
Created attachment 202772 [details]
Fill default configuration with the same attributes that are used by LaunchStapGraph

When user Clicks in 'Profile as'->'Profile Configurations' and click in new 'Systemtap ' the new created configuration will be filled with the same attributes that would be used if the user has run the 'Profile as'->'Function Callgraph'.
I created this because some users want to change some attributes from the default callgraph behavior and it is hard to set all attributes from scratch.
The patch is also available at: https://github.com/obusatto/linuxtools/commits/callgraph
Comment 9 Roland Grunberg CLA 2011-09-19 10:05:09 EDT 
resolved (fixed).
Comment 10 Wainer dos Santos Moschetta CLA 2011-09-19 10:31:12 EDT 
(In reply to comment #9)
> resolved (fixed).

Will it be fixed on Linux Tools 0.8.1?
Comment 11 Roland Grunberg CLA 2011-09-19 10:42:16 EDT 
The due date for 0.8.1 bug fixes was September 1st, so this won't make it into that release.