Bug 35358 - [Global Actions] missing icon in File / Refresh menu
Summary: [Global Actions] missing icon in File / Refresh menu
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P5 minor (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on: 204135
Blocks:
  Show dependency tree
 
Reported: 2003-03-20 08:12 EST by Adam Kiezun CLA
Modified: 2007-10-30 09:04 EDT (History)
2 users (show)

See Also:


Attachments
Patch to change the ActionFactory class to create WorkbenchCommandAction. (3.56 KB, patch)
2007-09-20 10:37 EDT, Remy Suen CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2003-03-20 08:12:01 EST
20030318
icon for File / Refresh menu is missing
Comment 1 Nick Edgar CLA 2003-03-21 12:08:40 EST
Should use same icon as Navigator.
Comment 2 Paul Webster CLA 2006-09-28 15:12:46 EDT
Is this still a problem in 3.3?

PW
Comment 3 Denis Roy CLA 2007-06-22 09:32:29 EDT
Changes requested on bug 193523
Comment 4 Remy Suen CLA 2007-09-19 10:06:21 EDT
The action is being created by the ActionFactory so using the org.eclipse.ui.commandImages extension point doesn't seem to cut it (unless I'm using it incorrectly). Paul, do we need to change this to a handler first?

The image is also in org.eclipse.ui.ide, so we'd need to copy/paste it to org.eclipse.ui and/or org.eclipse.ui.workbench.
Comment 5 Paul Webster CLA 2007-09-20 09:27:10 EDT
Probably the most correct option would be to turn ActionFactory.REFRESH into a WorkbenchCommandAction

Then copy the icon to org.eclipse.ui and add it as a commandImages extension.

Then we need to make sure there's a default path through WorkbenchCommandAction and super-classes that uses  the ICommandImageService if no image was set through the IAction interface.

PW
Comment 6 Remy Suen CLA 2007-09-20 10:37:41 EDT
Created attachment 78853 [details]
Patch to change the ActionFactory class to create WorkbenchCommandAction.

This patch updates the ActionFactory class and includes the updated diff for the commandImages extension in the plugin.xml as well as the refresh_nav.gif image.
Comment 7 Paul Webster CLA 2007-09-25 13:53:11 EDT
Released to HEAD >20070925
PW
Comment 8 Paul Webster CLA 2007-10-30 09:04:13 EDT
In I20071030-0010
PW