Bug 353047 - [JFace] Introduce a file list editor for preference pages
Summary: [JFace] Introduce a file list editor for preference pages
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2011-07-25 17:01 EDT by Johan Westling CLA
Modified: 2013-03-18 07:31 EDT (History)
3 users (show)

See Also:

Attachments
Implementation for a File list field editor (3.88 KB, patch)
2011-07-25 17:04 EDT, Johan Westling CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Westling CLA 2011-07-25 17:01:10 EDT 
Build Identifier: M20110720-0800

In the current API for preference pages (class org.eclipse.jface.preference.FieldEditorPreferencePage) there are field editors (subclasses of org.eclipse.jface.preference.FieldEditor) for string, file, directory, list of directories, etc, but there is no field editor for list of files.
It would be useful with a field editor class for list of files that could be used for preference pages (eg. preference pages for eclipse itself or third party plugins). 
Will attach a patch for an implementation of a file list field editor. The code is inspired (copy and paste) from the existing org.eclipse.jface.preference.PathEditor which is a field editor for list of paths (directories). The proposed field editor does the same as PathEditor but for list of files rather than list of paths.


Reproducible: Always

Steps to Reproduce:
N/A
Comment 1 Johan Westling CLA 2011-07-25 17:04:02 EDT 
Created attachment 200312 [details]
Implementation for a File list field editor
Comment 2 Oleg Besedin CLA 2011-07-26 09:40:17 EDT 
It would be interesting to see if existing preference pages (for instance, the workspace list on the General -> Startus and Shutdown -> Workspaces) can be updated to use this.
Comment 3 Johan Westling CLA 2011-07-26 14:40:01 EDT 
I guess the preference page General -> Startup and Shutdown -> Workspaces would use the existing 
org.eclipse.jface.preference.PathEditor since it is a list of diretories rather than files, but I am sure it would be useful somewhere. I have used it in a plugin in specific for the company I work for.
Comment 4 Paul Webster CLA 2012-11-07 10:56:33 EST 
(In reply to comment #1)
> Created attachment 200312 [details]
> Implementation for a File list field editor

Do you think this is still useful for Kepler?

PW
Comment 5 Johan Westling CLA 2012-11-18 16:41:56 EST 
(In reply to comment #4)
Yes, I still think it is useful. I use it in a plugin used at the company I work for. I think it would be useful for other plugin developers and maybe also for eclipse itself.
Comment 6 Dani Megert CLA 2013-02-07 03:54:54 EST 
One of our general rules is, that we do not add things which we don't use ourselves. So, unless there is at least one place where we can also use the file list editor, we should wait to put it in.
Comment 7 Paul Webster CLA 2013-02-07 13:59:04 EST 
Are you interested in trying to replace some of our uses in the eclipse preference pages, like General -> Startup and Shutdown -> Workspaces ?

PW