Community
Participate
Working Groups
I'm getting this in 3.7RC3 so I can't close a dirty compare editor. java.lang.NullPointerException at org.eclipse.team.internal.ui.synchronize.LocalResourceSaveableComparison.getName(LocalResourceSaveableComparison.java:250) at org.eclipse.ui.internal.SaveablesList.promptForSaving(SaveablesList.java:514) at org.eclipse.ui.internal.SaveablesList.promptForSavingIfNecessary(SaveablesList.java:433) at org.eclipse.ui.internal.SaveablesList.preCloseParts(SaveablesList.java:388) at org.eclipse.ui.internal.SaveablesList.preCloseParts(SaveablesList.java:347) at org.eclipse.ui.internal.WorkbenchPage.closeEditors(WorkbenchPage.java:1426) at org.eclipse.ui.internal.WorkbenchPage.closeEditor(WorkbenchPage.java:1514) at org.eclipse.ui.internal.EditorPane.doHide(EditorPane.java:61) at org.eclipse.ui.internal.PartStack.close(PartStack.java:537) at org.eclipse.ui.internal.EditorStack.close(EditorStack.java:206) at org.eclipse.ui.internal.PartStack$1.close(PartStack.java:120) at org.eclipse.ui.internal.presentations.util.TabbedStackPresentation$1.handleEvent(TabbedStackPresentation.java:83) at org.eclipse.ui.internal.presentations.util.AbstractTabFolder.fireEvent(AbstractTabFolder.java:269) at org.eclipse.ui.internal.presentations.util.AbstractTabFolder.fireEvent(AbstractTabFolder.java:278) at org.eclipse.ui.internal.presentations.defaultpresentation.DefaultTabFolder.access$1(DefaultTabFolder.java:1) at org.eclipse.ui.internal.presentations.defaultpresentation.DefaultTabFolder$1.closeButtonPressed(DefaultTabFolder.java:71) at org.eclipse.ui.internal.presentations.PaneFolder.notifyCloseListeners(PaneFolder.java:631) at org.eclipse.ui.internal.presentations.PaneFolder$3.close(PaneFolder.java:206) at org.eclipse.swt.custom.CTabFolder.onMouse(CTabFolder.java:1598) at org.eclipse.swt.custom.CTabFolder$1.handleEvent(CTabFolder.java:261) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3586) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3207) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494) at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577) at org.eclipse.equinox.launcher.Main.run(Main.java:1410) at org.eclipse.equinox.launcher.Main.main(Main.java:1386)
Sorry, but I cannot reproduce with I20110528-0800 + JGit/EGit 1.0.0.201105191813. I will update EGit and try again in a minute.
With a little help from James I found it using EGit 1.0.0.201105291713: 1. Select a folder (package) 2. Right click on it and drill down to Compare with > Git Index 3. Double-click on a file in Git Tree Compare view 4. Switch to left side of the Compare editor 5. Make change 6. Try to close the editor => comment 0
On discussion with Tomasz this has the same root cause as bug 347557, so fixing one will likely fix both.
This is caused by Bug 340666 in Compare.
(In reply to comment #3) > On discussion with Tomasz this has the same root cause as bug 347557, so fixing > one will likely fix both. I'm marking it as a duplicate of bug 347557, I already started working on both problems on bug 347557. *** This bug has been marked as a duplicate of bug 347557 ***
