Bug 347106 - saving password fails if secure storage is not available
Summary: saving password fails if secure storage is not available
Status: RESOLVED DUPLICATE of bug 429678
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P2 major with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks:
 
Reported: 2011-05-25 02:06 EDT by Jacek Jaroczynski CLA
Modified: 2014-11-28 12:45 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Jaroczynski CLA 2011-05-25 02:06:40 EDT 
Build Identifier: 

Mylyn stores task repositories passwords in Secure Storage. If Eclipse cannot write to the configured directory/file and Mylyn cannot store Repository password, it fails silently. 

It would be great to have some message.

Reproducible: Always

Steps to Reproduce:
https://studio.atlassian.com/browse/PLE-1308
Comment 1 Steffen Pingel CLA 2011-05-25 09:13:24 EDT 
Agreed, the error handling needs to be improved.
Comment 2 Michael Meß CLA 2012-06-06 05:39:41 EDT 
I can confirm this issue.

When unchecked "Save password" validate says "OK".
Then checking "Save password" validate says "invalid login".
Again unchecking "Save password" and validate says "OK".

When multiple failed logins occur subsequently, Jira requires a Web-Login with Captcha entered, before login can be successful, and a popup tells you to do that.

Expected behaviour would be that the password gets validated first, and if it is valid, it should be saved. 
After saving, it should be reread and compared with the password previously saved to warn the user, if the saved password is not correct because saving was not successful.
A good warning message in this case would be "Validation OK, but saving password failed."
Otherwise any subsequent request will fail silently.
Comment 3 Jacek Jaroczynski CLA 2012-06-08 02:54:22 EDT 
In case you have following in your stacktrace:
org.eclipse.equinox.security.storage.StorageException: No secure storage modules found

here is a link to the related issue: 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=329615
Comment 4 Michael Meß CLA 2012-06-11 02:22:15 EDT 
Yes, I saw such an exception stack trace in the error log.

That bug seems to be very old and still present. I have added my stack trace from a newer Eclipse version there.
Comment 5 Michael Meß CLA 2013-02-05 11:13:50 EST 
A possible workaround could be to avoid the interactive password dialog and store the master password in a file.
Probably it could fail to ask for the master password for any reason and cause the secure storage to fail.

How to disable interactive password dialog and store the master password in a file is described in the comments of the bug 241223:
 
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=241223 and read the comments 2-6 of that bug.

This might help as a workaround and may help to narrow down the bug.
Comment 6 Jacek Jaroczynski CLA 2014-04-28 04:31:41 EDT 
Customers are really suffering from this issue. We get several support requests related to this bug and also some comunity questions like this one: https://answers.atlassian.com/questions/77259/eclipse-jira-plugin-does-not-send-password
Comment 7 Sam Davis CLA 2014-11-28 12:45:18 EST 
This was fixed.

*** This bug has been marked as a duplicate of bug 429678 ***