Bug 346743 - [UI] Support of in-line commenting
Summary: [UI] Support of in-line commenting
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 0.11.0   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 0.12.0   Edit
Assignee: Sebastien Dubois CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan, ui
Depends on:
Blocks:
 
Reported: 2011-05-20 13:10 EDT by Alvaro Sanchez-Leon CLA
Modified: 2012-10-16 10:31 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2011-05-20 13:10:47 EDT
The Mylyn Reviews framework has the component needed for in-line commenting, 
ready to be adopted in R4E.
Comment 1 Sebastien Dubois CLA 2012-08-03 15:05:42 EDT
As of 2012-08-03, here is the status:

Implementation is done (first version) and the code, tested, and is ready for review.  There are still a few issues/limitations/unimplemented stuff:

1- It would be nice to connect the R4E editors directly to the properties view to show the Properties for the R4E elements when the elements are selected in the annotation hover popup window.  Right now as a hack we activate the corresponding element in the navigator view to get the properties but that has side effects.

2- We should try to use markers to show the R4E elements in the single editor rather than annotations directly.  This will enable us to blend more nicely into the editor and also allow the possibility of showing the R4E anomalies in the problems view and the delta/selections in the tasks view.  However this only works for resource files (i.e. not for external files) and if we are to do that with the current implementation the anomaly markers are duplicated if both a compare editor and a signle editor using the same document are open at the same time.  Markers do not work in the compare editor

3- In the single editor the non-R4E annotation markers icons are shown, but the hover popup window for these do not display any information.  This is because only 1 annotation model can be seen at any given time in the source viewer.  THis need to be investigated

4- When a compare editor and a signle editor are open for the same file, selecting an annotation on the compare editor sets the focus to the same element in the single editor.  This is probably related to point #1

5- The R4E Annotation Sticky hover does not resize properly when its child tree viewer is expanded/collapsed

6- The overview ruler in the compare editor does not show R4E markings, even if the OverviewRuler paint method seems to be called properly.  For now we removed trhe rules since it is useless

7- The copy/merge command in the compare editor was not disabled as suggested by users.  This needs to be discussed first
Comment 2 Sebastien Dubois CLA 2012-10-02 15:27:43 EDT
Functionality is now delivered and will be included in next release