Bug 346734 - [UI] Creating Delta's shall not open the compare editor (too slow)
Summary: [UI] Creating Delta's shall not open the compare editor (too slow)
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 0.9   Edit
Assignee: Sebastien Dubois CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
Depends on:
Blocks:
 
Reported: 2011-05-20 12:42 EDT by Alvaro Sanchez-Leon CLA
Modified: 2012-01-17 22:49 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2011-05-20 12:42:58 EDT
the current approach to calculate the deltas / hunks from the comparison of two files is to open the compare editor, this deteriorates performance. It shall use a differencer instead of relying on the Eclipse compare editor.
Comment 1 Alvaro Sanchez-Leon CLA 2011-06-10 13:18:44 EDT
this functionality would be needed for statistics as Birt reports rely on deltas to estimate the Lines of code changes which is the input to derive other results.
Comment 2 Sebastien Dubois CLA 2011-06-10 14:10:55 EDT
THe proble happens because for now we open the compare editor in order to get he differences between the base and target files.  We should use the Eclipse Differencer engine to get the differences in a separate thread without having to open the compare editor to do so.  This will also solve another problem where only JDT and CDT files can be generated with Delta elements.
Comment 3 Sebastien Dubois CLA 2011-06-24 22:27:33 EDT
We now do the comparisons internally when importing change sets.  

Also, there are many improvements for cursor positioning and range highlighting for Contents/Anomalies when operating the compare editor.

Take note that there are a few dirty hacks that were needed to implement the full functionality.  This is because the current Compare Editor does not directly implement many of the Text Editor functionalities.  Hopefully, this can be streamlined when/if changes are introduced in the Compare Editor in the future.