Bug 346194 - [server] Address TODOs in git tests saying "don't create URIs out of thin air"
Summary: [server] Address TODOs in git tests saying "don't create URIs out of thin air"
Status: RESOLVED WONTFIX
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Git (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P4 minor (vote)
Target Milestone: ---   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks: 342820
  Show dependency tree
 
Reported: 2011-05-18 04:12 EDT by Tomasz Zarna CLA
Modified: 2015-05-05 14:39 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-05-18 04:12:17 EDT 
The number of places where we create URIs out of thin air to execute a test scenario is getting bigger every week. This should be fixed.
Comment 1 Tomasz Zarna CLA 2011-08-02 05:37:28 EDT 
The majority of those TODOs have been fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=95310d24f6886dee0dc0477ebf429f5b8c8a45b0. The class that still does a lot of URI crafting is GitDiffTest.java (10). Other two are GitCheckoutTest.java (1) and GitResetTest.java (1).
Comment 2 Tomasz Zarna CLA 2012-04-04 11:15:24 EDT 
(In reply to comment #1)
> The class that still does a lot of URI crafting is GitDiffTest.java (10).

I'll clean up the test while working on bug 347943 and bug 376093.
Comment 3 John Arthorne CLA 2015-05-05 14:39:31 EDT 
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html