Bug 342820 - [server][test] Reduce boiler plate code in git tests
Summary: [server][test] Reduce boiler plate code in git tests
Status: RESOLVED WONTFIX
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Git (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on: 346194 353552 370696
Blocks:
  Show dependency tree
 
Reported: 2011-04-14 06:26 EDT by Tomasz Zarna CLA
Modified: 2015-05-05 16:21 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-04-14 06:26:12 EDT 
The current shape of all tests under org.eclipse.orion.server.tests.servlets.git contains a lot of boiler plate code. Some pieces that can be extracted to methods:
* clone a repository
* link to a repository
* status verification
* common operations like add, commit etc
Comment 1 Tomasz Zarna CLA 2011-04-18 12:08:17 EDT 
(In reply to comment #0)
> * clone a repository

Fixed with http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=371c693b55f79a7413cb238d01c492eaaccfc262.
Comment 2 Tomasz Zarna CLA 2011-04-18 12:52:43 EDT 
(In reply to comment #0)
> * link to a repository

Fixed with http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=e997e98c7072b7bdd6bba43e2665abb73d4279a7.
Comment 4 Tomasz Zarna CLA 2011-04-20 08:55:35 EDT 
create project with content location (git repo) : http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=538f555283ab97c9f76ca8f3d8a566945b7340c4
Comment 5 Tomasz Zarna CLA 2011-05-06 05:42:41 EDT 
At the same time, it would be great if we got rid of all places where we create URIs out of thin air.
Comment 6 Tomasz Zarna CLA 2011-05-17 07:33:01 EDT 
It's much better now, reducing priority.
Comment 7 John Arthorne CLA 2015-05-05 16:21:01 EDT 
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html