Community
Participate
Working Groups
we need a way to show that an comment is private. Now I do the background work and show the comments in BOLD and ITALIC Font until we did an UI review and come up with an better way to present this to the user.
We shouldn't modify the comment text style itself as that will interfere with the WikiText rendering. Could we decorate the header somehow, e.g. by showing an extra icon?
Steffen, I only change the hyperlink text style. Is this OK? BTW I need to change CommentViewer and this is a private class in TaskEditorCommentPart. Should I refactor this so it is possible to override some methods in a subclass for the bugzilla package?
(In reply to comment #2) > I only change the hyperlink text style. Is this OK? I'm not sure I understand how that is done? > BTW I need to change CommentViewer and this is a private class in > TaskEditorCommentPart. > > Should I refactor this so it is possible to override some methods in a subclass > for the bugzilla package? No, I would prefer if we found a solution that didn't require modification or exposure of these classes. We want to make the comment viewers extensible but it's a larger undertaking that I don't want to commit to for 3.6. Couldn't we simply decorate the person icon in the comment header to show that a comment is private?
(In reply to comment #3) > (In reply to comment #2) > > I only change the hyperlink text style. Is this OK? > > I'm not sure I understand how that is done? > > > BTW I need to change CommentViewer and this is a private class in > > TaskEditorCommentPart. > > > > Should I refactor this so it is possible to override some methods in a subclass > > for the bugzilla package? > > No, I would prefer if we found a solution that didn't require modification or > exposure of these classes. We want to make the comment viewers extensible but > it's a larger undertaking that I don't want to commit to for 3.6. OK! > > Couldn't we simply decorate the person icon in the comment header to show that > a comment is private? If we want to do this we need the bugzilla specific attribute for hold the private value in CommentViewer.createTitleHyperLink. We need something like: TaskAttribute isprivate = taskComment.getTaskAttribute().getAttribute("isprivate"); is this OK?
Yes, adding a new attribute for the private flag seems very reasonable to me.
Created attachment 195783 [details] patch V1 Steffen, can you please review. Can we do this for 3.6?
Created attachment 195784 [details] mylyn/context/zip
The concept of the patch looks fine to me. Here are a few comments: * The isPrivate flag should be added to ITaskComment and TaskCommentMapper to expose it in the API for other connectors. * The font instance in createTitleHyperLink() needs to be disposed when the editor is closed. It's better to only create the font once per comment part. Can you clean the patch a bit, e.g. revert changes from private to protected, remove commented out code, and post another iteration?
One more thought, would it make sense to add a tooltip to indicate that it's a private comment?
Created attachment 196286 [details] patch V2 (In reply to comment #8) > The concept of the patch looks fine to me. Here are a few comments: > > * The isPrivate flag should be added to ITaskComment and TaskCommentMapper to > expose it in the API for other connectors. > * The font instance in createTitleHyperLink() needs to be disposed when the > editor is closed. It's better to only create the font once per comment part. > > Can you clean the patch a bit, e.g. revert changes from private to protected, > remove commented out code, and post another iteration? Here we go. (In reply to comment #9) > One more thought, would it make sense to add a tooltip to indicate that it's a > private comment? ToolTip is now "Private comment from {0}
Created attachment 196287 [details] mylyn/context/zip
Steffen, should i commit patch v2 for 3.6 or are we to late for this?
+1 looks good to me. Please feel fee to commit.
(In reply to comment #13) > +1 looks good to me. Please feel fee to commit. Done!
Created attachment 196930 [details] fix for comment font
Thanks! I have committed a small fix to set the font properly on non-private comments. Can you attach a screenshot of a task editor that shows a private comment so I can include it in the New & Noteworthy? Anything else left to do here? The summary of the bug report states that private attachments should also be supported. Was that part of the patch? If not we should create a separate bug.
Created attachment 196955 [details] screenshot of the comment section
I create bug#347718 for attachments, so we can close this!
