Community
Participate
Working Groups
1/ Create a QuerySet owning a query 2/ Create the java class for this query and declare it in the QuerySet file -> that works fine 3/ Create a super-class for your Java Query. This super-class should implement IJavaModelQuery 4/ Delete "implements IJavaModelQuery" in your class implementing the Query -> the Query Editor indicates that you have an error : "yourQuery.java doesn't implements IJavaModelQuery". This error is wrong, because this interface is now implemented in your super-class.
Created attachment 195955 [details] Patch for Bug 345370 Hi Vincent, I've added the verification of the superClasses hierarchy in our querySet validation process. Please note that if the superClass is not contained by an installed plugin, it will not be hot loaded and you will not be able to execute your query. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Hello, This bug is not blocking or critical. In conformance with the ramp down policy [1], the commit of its fixing will then be delayed to version 0.1.1 (Indigo SR1). [1] http://wiki.eclipse.org/Modeling_Project_Ramp_Down_Policy Regards, Gregoire Dupe
Created attachment 196548 [details] Patch for Bug 345370 non regression test Hi, Please find attache a non regression test for this kind of query. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Created attachment 197961 [details] Patch for Bug 345370 non regression test Hi, Please find attached an updated version of the non regression test. Test resources were not contained in the correct folder. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Created attachment 198122 [details] Patch for Bug 345370 Hi, I was able to reduce my previous correction using IType.newSupertypeHierarchy().getAllTypes() method. This does not changes behavior, and every unit test succeeded on my computer (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Created attachment 198123 [details] Patch for Bug 345370 non regression test Hi, I forgot to cover one use case in my previous non regression test: "The query can implements an interface which itself extends IJavaModelQuery" This new version covers this use case (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Created attachment 198640 [details] Unit test to check thath the qualified name is used in the validation The patch in the attachment 198123 [details] dose not totally solves the problem. The test is done on a class name rather than on the class qualified name. Here is a unit test to reproduce the problem. (a) I, Gregoire Dupe, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features.
Comment on attachment 198122 [details] Patch for Bug 345370 review-, cf. attachment 198640 [details]
