Bug 345223 - Ant and External tool tabs refer to Java help topics
Summary: Ant and External tool tabs refer to Java help topics
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.8 M1   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2011-05-10 00:30 EDT by Michael Rennie CLA
Modified: 2011-07-06 03:35 EDT (History)
3 users (show)

See Also:
curtis.windatt.public: review+

Attachments
fix (38.03 KB, patch)
2011-05-17 23:58 EDT, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2011-05-10 00:30:43 EDT 
When you activate the context help in the launch configuration dialog for tabs shared from platform Debug you get Java help topics appearing. 

We should be calling ILaunchConfigurationTab#setHelpContextId(..) for these tabs when we add them to their respective tab groups.

Affected Tabs:

1. Refresh tab
2. Classpath tab
3. Environment tab
4. Common tab
5. JRE tab
Comment 1 Michael Rennie CLA 2011-05-17 23:58:24 EDT 
Created attachment 195935 [details]
fix

The patch provides all of the missing context ids for Ant and External Tools and updates the doc
Comment 2 Michael Rennie CLA 2011-05-18 00:28:25 EDT 
Curtis and Markus, please test the patch for RC2.
Comment 3 Curtis Windatt CLA 2011-05-18 15:29:48 EDT 
Patch works, but this is a large number of changes for RC2.  It only adds some basic context help information that doesn't differ a whole lot from the JDT help.  I think it should be put off until 3.8, but it shouldn't break anything if it is put in 3.7.
Comment 4 Michael Rennie CLA 2011-05-18 16:25:33 EDT 
I've been undecided about this going in to RC2 all week, the patch is large - the main reason I was not going to add it. In light of the size and non-critical nature, I'm going to bump it to 3.8.
Comment 5 Michael Rennie CLA 2011-06-29 12:11:58 EDT 
applied to HEAD