Bug 344938 - Line height and vertical alignment properties does not work for PDF outputs
Summary: Line height and vertical alignment properties does not work for PDF outputs
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BIRT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Birt-Report-inbox@eclipse.org CLA
QA Contact: Xiaoying Gu CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-06 05:34 EDT by Jiju CLA
Modified: 2016-06-06 13:54 EDT (History)
3 users (show)

See Also:

Attachments
buggy css-report (only worked with my.css) (12.91 KB, application/xml)
2011-06-20 06:59 EDT, jan CLA 		no flags Details
corresponding css-file to rptdesign-file (248 bytes, text/plain)
2011-06-20 07:01 EDT, jan CLA 		no flags Details
1 of 2 files for line height fix (4.64 KB, text/x-java)
2016-06-06 13:54 EDT, Dan Fin CLA 		no flags Details
2 of 2 files for line height fix (18.25 KB, text/x-java)
2016-06-06 13:54 EDT, Dan Fin CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiju CLA 2011-05-06 05:34:00 EDT 
Build Identifier: 2.5.2

1. The line height property, which allows us to reduce line spacing between two lines, does not work for PDF report outputs.  The same works fine for HTML outputs.
2. Vertical alignment also not working the way it is supposed to be.  Does not align the items as we set it in design for PDF outputs, but works properly for HTML outputs. 



Reproducible: Always

Steps to Reproduce:
1.create a new report with some table, and data elements in it.
2.Set the line height property for text in advanced property, some 2-3 pts more than the font size set for the element, remove all padding set for row, columns and elements.  Set vertical alignment  to top.
3.View report as PDF
Comment 1 Xiaoying Gu CLA 2011-05-09 01:57:04 EDT 
Would you please attach a sample report?
Comment 2 jan CLA 2011-06-20 06:59:10 EDT 
Created attachment 198245 [details]
buggy css-report (only worked with my.css)

Report contained the unexpected css-behavior.  
* the grid ignore vertical-align in design- and preview mode
* the table-header ignore vertical-align only in preview-mode
Comment 3 jan CLA 2011-06-20 07:01:28 EDT 
Created attachment 198246 [details]
corresponding css-file to rptdesign-file

buggy css-report depends on this css-file.
Comment 4 Xiaoying Gu CLA 2011-06-24 05:00:29 EDT 
(In reply to comment #2)
> Created attachment 198245 [details]
> buggy css-report (only worked with my.css)
> 
> Report contained the unexpected css-behavior.  
> * the grid ignore vertical-align in design- and preview mode
> * the table-header ignore vertical-align only in preview-mode

valign property is not a css property, so it's not supported in BIRT.

For vertial-align doesn't work in HTML with the fixed layout, please see:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=271984#c8

For vertical-align doesn't work on .grid issue, since vertical-align property can not be inherit fro parent (http://www.w3schools.com/css/pr_pos_vertical-align.asp), you should set the vertical align on grid cell or grid row.
Comment 5 Dan Fin CLA 2016-06-06 13:52:31 EDT 
We fixed this bug in birt 4.4.2.  I attached the 2 changed java files in their project. I hope you guys can incorporate this into the source code.
Dan
Comment 6 Dan Fin CLA 2016-06-06 13:54:14 EDT 
Created attachment 262258 [details]
1 of 2 files for line height fix

1 of 2 files for line height fix
Comment 7 Dan Fin CLA 2016-06-06 13:54:44 EDT 
Created attachment 262259 [details]
2 of 2 files for line height fix