Bug 344770 - CommonImages.FIND_CLEAR and FIND_CLEAR_DISABLED should have a transparent background
Summary: CommonImages.FIND_CLEAR and FIND_CLEAR_DISABLED should have a transparent bac...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 3.6   Edit
Assignee: Sam Davis CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2011-05-04 17:44 EDT by Sam Davis CLA
Modified: 2012-03-21 12:17 EDT (History)
1 user (show)

See Also:

Attachments
patch for DatePicker (940 bytes, patch)
2011-05-06 12:23 EDT, Sam Davis CLA 		steffen.pingel: iplog+
Details | Diff
mylyn/context/zip (22.77 KB, application/octet-stream)
2011-05-06 12:23 EDT, Sam Davis CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2011-05-04 17:44:42 EDT 
CommonImages.FIND_CLEAR and CommonImages.FIND_CLEAR_DISABLED should have a transparent background so that widgets that use them can be used with non-white background colours.
Comment 1 Steffen Pingel CLA 2011-05-06 10:40:11 EDT 
According to gimp the background on these images is transparent. Note that some Windows versions have problems showing transparent images properly on certain controls.
Comment 2 Sam Davis CLA 2011-05-06 12:23:33 EDT 
Created attachment 194959 [details]
patch for DatePicker

Thanks for looking in to this Steffen. It turns out the problem is that DatePicker does not set the background on the clear button. Here's a patch.
Comment 3 Sam Davis CLA 2011-05-06 12:23:35 EDT 
Created attachment 194960 [details]
mylyn/context/zip
Comment 4 Steffen Pingel CLA 2011-05-06 12:43:52 EDT 
Reopening to merge patch.
Comment 5 Steffen Pingel CLA 2011-05-06 12:47:57 EDT 
Thanks for looking into this. I have applied the patch.