Bug 344416 - improve tab order on repository settings page
Summary: improve tab order on repository settings page
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P4 trivial (vote)
Target Milestone: 3.10   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks: 336434
  Show dependency tree
 
Reported: 2011-05-02 04:17 EDT by Ankur Sharma CLA
Modified: 2013-10-07 15:18 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ankur Sharma CLA 2011-05-02 04:17:31 EDT
Eclipse build id I20110428-0848
Mylyn version 3.5


1. Open the task repository view
2. select a bugzilla repository (in my case Eclipse.org)
3. open the properties

This will open the 'Properties of Task Repository" wizard. Note that the check box "anonymous" is selected by default

4. Use Tab key to navigate the controls.

once the anonymous check box is unchecked the tab order is


... Label text box > Disconnected check box > User Id text box > Anonymous check box > password check box > Save password check box

it will be good to have the user id text box and password text box one after the other. that is,


... Label text box > Disconnected check box > Anonymous check box >  User Id text box > password check box > Save password check box
Comment 1 Tomasz Zarna CLA 2013-08-22 06:13:02 EDT
(In reply to comment #0)
> This will open the 'Properties of Task Repository" wizard. Note that the
> check box "anonymous" is selected by default

In Eclipse 3.8 on Windows I get the Label text box selected by default.
 
> it will be good to have the user id text box and password text box one after
> the other. that is,
> ... Label text box > Disconnected check box > Anonymous check box >  User Id
> text box > password check box > Save password check box

What's the rationale behind this?
Comment 2 Tomasz Zarna CLA 2013-09-24 06:25:28 EDT
(In reply to comment #1)
> What's the rationale behind this?

nm, I got it.
Comment 3 Tomasz Zarna CLA 2013-09-24 06:26:06 EDT
Review: https://git.eclipse.org/r/#/c/16718/
Comment 4 Sam Davis CLA 2013-10-07 13:22:02 EDT
Steffen, I was going to wait until after 3.10 to merge this as I'm not sure whether it's a good idea, but feel free to merge it now if you think it is.
Comment 5 Steffen Pingel CLA 2013-10-07 13:43:41 EDT
I think we should just make a call whether we want this change or not. If it's not a good idea then let's abandon it and close this request. It's a trivial change and I'd rather move on then iterate over something like this for weeks.
Comment 6 Sam Davis CLA 2013-10-07 14:42:36 EDT
Ok, I have merged it. Thanks for the suggestion.
Comment 7 Tomasz Zarna CLA 2013-10-07 15:18:20 EDT
Fixed in 31148a3ccf2ca4836936069fe478dc1f450690a0