Bug 343822 - RTL support for text documents
Summary: RTL support for text documents
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2011-04-26 07:19 EDT by Dotan Cohen CLA
Modified: 2019-11-18 16:10 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dotan Cohen CLA 2011-04-26 07:19:31 EDT
Build Identifier: M20100211-1343

I prefer to open my assignments / specs in a split editor but Eclipse does not handle RTL directionality. Please add this feature to an otherwise terrific editor environment. Thanks!

Reproducible: Always
Comment 1 Dani Megert CLA 2011-04-26 08:30:07 EDT
(In reply to comment #0)
> Build Identifier: M20100211-1343
> 
> I prefer to open my assignments / specs in a split editor but Eclipse does not
> handle RTL directionality.
Which editor? Can you give more details? The textual editors are in RTL if the workbench is in that mode (e.g. by specifying -dir rtl).
Comment 2 Dotan Cohen CLA 2011-04-26 08:44:29 EDT
When in the Java perspective I will open File->Open then select a UTF-8 text file to open in a new editor. I do not know if the "standard" Java editor has a name, so I can supply a screenshot if need be.

Note that the workbench is NOT in RTL mode. I prefer to keep Eclipse in English with the standard workbench to assist in Googling the issues that I come across. There should be no restriction on what content is viewed (RTL/LTR) by the UI settings! Assuming that one will always use the same content directionality as his UI is wrong for _all_ use cases!
Comment 3 Dani Megert CLA 2011-04-26 08:57:39 EDT
On Windows you could use Ctrl+LeftShift/RightShift to switch the orientation of a text controls. Unfortunately this is not yet working for textual editors, see bug 291949.

Moving to SWT to decide whether they want to add orientation switching on any platform.
Comment 4 Felipe Heidrich CLA 2011-04-26 11:44:20 EDT
(In reply to comment #3)
> Moving to SWT to decide whether they want to add orientation switching on any
> platform.

You mean adding the same support we have on Windows (bug 289752) to Linux-gtk ?
I think the answer is no. Using Ctrl+RightShift/Ctrl+LeftShift to switch the orientation is not a platform behaviour on Linux.
Comment 5 Dotan Cohen CLA 2011-04-27 04:06:05 EDT
> You mean adding the same support we have on Windows (bug 289752) to
> Linux-gtk ? I think the answer is no. Using Ctrl+RightShift/Ctrl+LeftShift
> to switch the orientation is not a platform behaviour on Linux.

We don't need platform behaviour, we need any behaviour. I am familiar with Ctrl+RightShift/Ctrl+LeftShift in some applications and with Ctrl+Shift+X from others (Mozilla for instance). Either one is fine. But add something!
Comment 6 Felipe Heidrich CLA 2011-05-10 11:43:22 EDT
(In reply to comment #5)
> We don't need platform behaviour, we need any behaviour. I am familiar with
> Ctrl+RightShift/Ctrl+LeftShift in some applications and with Ctrl+Shift+X from
> others (Mozilla for instance). Either one is fine. But add something!

I understand, Dani and I were just trying to figure out where the feature should be added. Personally I think this type of feature should have a way, if implemented, to be disabled or/and customized. Thus, it needs an UI for it (i.e Preference Page). Moving back to Text.

Dani, on Windows, you only get the Ctrl+RightShift/Ctrl+LeftShift when there is a bidi keyboard layout installed. As most user do not want this feature. On Linux I cannot do the same (it would require BidiUtil to be implemented).
Comment 7 Dani Megert CLA 2011-05-10 11:48:02 EDT
Felipe, I have to move this back: the initial support to allow switching the direction dynamically would have to come from SWT / StyledText. Only when that API is in place, we can start thinking of adding UI or commands for this.
Comment 8 Felipe Heidrich CLA 2011-05-10 12:18:59 EDT
(In reply to comment #7)
> Felipe, I have to move this back: the initial support to allow switching the
> direction dynamically would have to come from SWT / StyledText. Only when that
> API is in place, we can start thinking of adding UI or commands for this.



Depending what you want to do the API is there (StyledText#setOrientation()).
I'm not sure if adding Ctrl+LeftShift/RightShift to Linux is the right thing to do, this feature could be presented as a menu item or something else.

How do you want to do this ?
Comment 9 Dani Megert CLA 2011-05-11 03:24:51 EDT
(In reply to comment #8)
> (In reply to comment #7)
> > Felipe, I have to move this back: the initial support to allow switching the
> > direction dynamically would have to come from SWT / StyledText. Only when that
> > API is in place, we can start thinking of adding UI or commands for this.
> 
> 
> 
> Depending what you want to do the API is there (StyledText#setOrientation()).
> I'm not sure if adding Ctrl+LeftShift/RightShift to Linux is the right thing to
> do, this feature could be presented as a menu item or something else.
> 
> How do you want to do this ?

Sorry Felipe, I missed that org.eclipse.swt.widgets.Control.setOrientation(int) (which is needed to correctly change the orientation for the whole editor not just the text) is now available in 3.7. I guess we could add a command on the Text level to support this.
Comment 10 Lars Vogel CLA 2019-11-14 02:13:53 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.
Comment 11 Dotan Cohen CLA 2019-11-18 16:10:49 EST
(In reply to Lars Vogel from comment #10)
> This bug hasn't had any activity in quite some time. Maybe the problem got
> resolved, was a duplicate of something else, or became less pressing for
> some reason - or maybe it's still relevant but just hasn't been looked at
> yet.
> 

I think that it is more likely that anybody who needs RTL support has found options other than Eclipse. I know that I haven't used Eclipse in at least six or seven years, and I do not recall seeing Eclipse in use at all for quite a few years.