Bug 343261 - PlatformUITest.testWithoutDisplayAccess_sync() fails on Java 7
Summary: PlatformUITest.testWithoutDisplayAccess_sync() fails on Java 7
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: Oleg Besedin CLA
QA Contact: Oleg Besedin CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 342688
  Show dependency tree
 
Reported: 2011-04-19 09:10 EDT by Dani Megert CLA
Modified: 2011-04-26 05:26 EDT (History)
3 users (show)

See Also:

Attachments
Patch (8.61 KB, patch)
2011-04-25 13:22 EDT, Oleg Besedin CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-04-19 09:10:49 EDT 
HEAD.

PlatformUITest.testWithoutDisplayAccess_sync() fails when run on a Java 7 JRE.

This test failed on two subsequent runs of the Eclipse SDK tests against an Oracle Java 7 JRE. Unfortunately I cannot reproduce it when running on my Windows or Linux box.

See also bug 331909.
Comment 1 Oleg Besedin CLA 2011-04-25 13:22:03 EDT 
Created attachment 194006 [details]
Patch

I can't reproduce that either. One possibility is that we don't re-sync values on several variables in the RCPTestWorkbenchAdvisor: the setters are done in "synchronized" blocks but getters access variables directly. 

Also the order of PlatformUITest still was incorrect: "testCreateAndRunWorkbenchWithExceptionOnStartup" should be done after testing all startup variables for the normal case. (The test variables are static.)

I'll also bunch together all asserts of startup variables; there is little reason to have them in separate tests.
Comment 2 Oleg Besedin CLA 2011-04-25 13:26:36 EDT 
Patch applied to CVS Head.
Comment 3 Dani Megert CLA 2011-04-26 05:26:45 EDT 
Thanks Oleg. We'll run the tests against Java 7 again once the remaining issues are fixed (see bug 342688).