Community
Participate
Working Groups
Build Identifier: CVS, 16.04.2011 The icon is not available in "Open Console". Reproducible: Always
Created attachment 193412 [details] an initial icon suggestion in grey scale
Ewgeni, if you are still interested, please update your icon to something matching other Eclipse icons L&F. Meanwhile I believe that we have already a matching icon (used for exception breakpoints), which I would like to set to the console. Having no icon doesn't look nice, and with the icon it is much easier to find. See attachment 272047 [details] to bug 529248 how it looks today.
New Gerrit change created: https://git.eclipse.org/r/114774
Created attachment 272050 [details] java stack trace console with icon (In reply to Eclipse Genie from comment #3) > New Gerrit change created: https://git.eclipse.org/r/114774 The attached picture shows how it looks like after the patch.
Gerrit change https://git.eclipse.org/r/114774 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=a1c3bfda63c3431b195e7ec1ed11597463c6c603
New Gerrit change created: https://git.eclipse.org/r/114790
Gerrit change https://git.eclipse.org/r/114790 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=97ab1fc3b64a1c556101f15c2aef3a25ff75fcdb
The new icon does not have any connection with console. If we don't have a new icon we can at least have the console icon with "J" from the Java Exception icon instead of simply reusing Java exception icon.
(In reply to Sarika Sinha from comment #8) > The new icon does not have any connection with console. If we don't have a > new icon we can at least have the console icon with "J" from the Java > Exception icon instead of simply reusing Java exception icon. I thought to add something like this but then decided against it. The context of all the menu entries is the console. There is no need to emphasize this again in the icon, especially because any attempt to add some extras to the main "console" icon part will result in about 5 x 5 pixel small "something", like OSGI console icon. So we will end with few indistinguishable console icons, similar to the OSGI console icon, and this does not make much sense for me. Instead, being already in the context of the console, we can emphasize what is shown *inside* the opened page, and this is in the "java stack trace" console the exception stack trace. So I've ended up with the "J!" icon shown for Java exceptions. Of course we could use something else for the icon, but I would really do not recommend to add a "console" to it.
Java Stack should not be directly associated to Java exception. We can paste any stack trace, It might be just coming from a log or to understand the flow. I see that OSGI icon does not look clear but CVS one is very clear and we should have all the icons in a similar style.
If we don't have a proper icon before M5, we should revert this. As we can not change this multiple times and confuse user.
New Gerrit change created: https://git.eclipse.org/r/114978
(In reply to Sarika Sinha from comment #11) > If we don't have a proper icon before M5, we should revert this. As we can > not change this multiple times and confuse user. (In reply to Eclipse Genie from comment #12) > New Gerrit change created: https://git.eclipse.org/r/114978 I've explained my thoughts in comment 9, so I will revert the changes. If someone wants to add a new icon: see the patch above where it should be configured.
Gerrit change https://git.eclipse.org/r/114978 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=f20e32d0b1b5a212e073fa7cc7fc7e458663d25a
What about reusing the stackframe image from junit? http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/plain/org.eclipse.jdt.junit/icons/full/eview16/stackframe.png Regarding whether to have the "screen" in all console icons: At least in my Eclipse installation the majority of available consoles does _not_ have this screen (e.g. m2e, spotbugs, xtext, ...). I tend to agree with Andrey, these icons are shown only in a single drop down menu where the context "console" is already completely clear. Those consoles also don't appear in Ctrl-3 searches (which would be an argument for showing the generic console background in the icon).
(In reply to Michael Keppler from comment #15) > What about reusing the stackframe image from junit? > http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/plain/org.eclipse.jdt.junit/ > icons/full/eview16/stackframe.png > > Regarding whether to have the "screen" in all console icons: At least in my > Eclipse installation the majority of available consoles does _not_ have this > screen (e.g. m2e, spotbugs, xtext, ...). I tend to agree with Andrey, these > icons are shown only in a single drop down menu where the context "console" > is already completely clear. Those consoles also don't appear in Ctrl-3 > searches (which would be an argument for showing the generic console > background in the icon). Sarika, WDYT? I would be OK with the icon.
(In reply to Andrey Loskutov from comment #16) > (In reply to Michael Keppler from comment #15) > > What about reusing the stackframe image from junit? > > http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/plain/org.eclipse.jdt.junit/ > > icons/full/eview16/stackframe.png > > > > Regarding whether to have the "screen" in all console icons: At least in my > > Eclipse installation the majority of available consoles does _not_ have this > > screen (e.g. m2e, spotbugs, xtext, ...). I tend to agree with Andrey, these > > icons are shown only in a single drop down menu where the context "console" > > is already completely clear. Those consoles also don't appear in Ctrl-3 > > searches (which would be an argument for showing the generic console > > background in the icon). > > Sarika, WDYT? I would be OK with the icon. Let me work on having the overlay "J" icon from JDT UI and overlay it on Console or the stackframe icon, let's see how does it come. If anyone else wants to try any overlay, you can. Does it sound ok?
New Gerrit change created: https://git.eclipse.org/r/130612
(In reply to Eclipse Genie from comment #18) > New Gerrit change created: https://git.eclipse.org/r/130612 This is based on the initial icon design. Overlay will not work as it is provided in plugin.xml. If this icon is acceptable, I am attaching the svg file and someone can help to generate 2x file from platform utility.
Created attachment 276161 [details] svg file
Seems okay to me. Funny enough however, only with your new icon I now realized there are 2 different kinds of similar console icons. Yours and the CVS console icon use a sharp rectangle in dark blue, new console and OSGI Host console use a rounded rectangle, light blue (like the console view itself). I'm happy with all of those. :)
I personally do not like the icon (reason already explained) but I'm for a progress on this bug, just because no icon is worse than some one.
Gerrit change https://git.eclipse.org/r/130612 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=b836bf126986d8ddcfe197536be7fe011d1671d6
New Gerrit change created: https://git.eclipse.org/r/132663
Released svg and png files.
Gerrit change https://git.eclipse.org/r/132663 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=7ae13a050bbaefcf5101ae2cd5c63b72ccf0aac5
Verified using Eclipse SDK Version: 2018-12 (4.10) Build id: I20181119-0600
