Bug 34259 - [EditorMgmt] drop-down: strange button enablement
Summary: [EditorMgmt] drop-down: strange button enablement
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2003-03-10 05:19 EST by Adam Kiezun CLA
Modified: 2009-12-12 15:39 EST (History)
1 user (show)

See Also:


Attachments
Patch file for org.eclipse.ui.workbench (current to July 24/03) for potential fix. (6.79 KB, patch)
2003-07-24 13:50 EDT, Debbie Wilson CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2003-03-10 05:19:21 EST
rc2
open a bunch of editors
press ctrl+shift+w
select some in the dialog
'close selected'
note, the OK button is now disabled although saying OK is _exactly_ what you 
want to do; you do not 'Cancel' because things happened already and they will 
not be undone

this is confusing
why not leave only 1 button (OK) in this dialog?
Comment 1 Nick Edgar CLA 2003-03-11 16:36:02 EST
It's confusing because OK really means "activate the selected editor".
Should rename "OK" to "Activate" and "Cancel" to "Close".
Comment 2 Andrew Irvine CLA 2003-04-10 11:09:30 EDT
Fixed in N20030411
Comment 3 Adam Kiezun CLA 2003-05-06 05:58:50 EDT
it still looks strange
'activate' applies to the selected editor
'close'    applies to the dialog

the 2 buttons sit close together, so you'd think that they apply to the same 
thing

every time i see it i think that 'close' will close the selected editor and 
then i remember that 'close' is 'close dialog' while 'activate' is 'activate 
editor'
Comment 4 Debbie Wilson CLA 2003-05-07 16:19:31 EDT
Simon,  Sorry if this is the wrong component.  Will watch to see where this is 
reassigned.
Comment 5 Simon Arsenault CLA 2003-05-08 09:33:39 EDT
Debbie - it was the correct category. Clearing the target milestone field.
Comment 6 Debbie Wilson CLA 2003-07-24 13:50:27 EDT
Created attachment 5549 [details]
Patch file for org.eclipse.ui.workbench (current to July 24/03) for potential fix.
Comment 7 Debbie Wilson CLA 2003-12-16 16:21:37 EST
A couple of issues remain outstanding on this PR:
1 - As far as style goes, labels for controls should end with ':'.

2 - It comes up with no selection.  It should select the active editor (if 
there is one).

3 - Activate is initially enabled even though there is no selection.  If you 
select something then clear it, Activate gets disabled (properly).
Comment 8 Michael Van Meekeren CLA 2006-04-21 13:19:06 EDT
Moving Dougs bugs
Comment 9 Susan McCourt CLA 2009-07-09 19:02:41 EDT
As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009
Comment 10 Boris Bokowski CLA 2009-11-17 13:03:29 EST
Remy is now responsible for watching the [EditorMgmt] component area.
Comment 11 Remy Suen CLA 2009-12-12 15:39:51 EST
(In reply to comment #7)
> 2 - It comes up with no selection.  It should select the active editor (if 
> there is one).

Except for this point, I believe everything else has been addressed as of I20091210-1301. I'm not familiar with what the dialog looked like six years ago but do not currently feel that there is a need to automatically select the active editor. If you feel otherwise, please feel free to make it known on this bug.