Bug 342318 - [Themes] Dark color schemes
Summary: [Themes] Dark color schemes
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6.2   Edit
Hardware: All Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-08 13:11 EDT by Juanjo Aguililla CLA
Modified: 2019-09-29 14:00 EDT (History)
7 users (show)

See Also:


Attachments
white console color within dark theme (182.55 KB, image/png)
2013-03-15 22:21 EDT, hooluupog CLA
no flags Details
white row and colum color within dark theme (17.21 KB, image/png)
2013-03-15 22:23 EDT, hooluupog CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Juanjo Aguililla CLA 2011-04-08 13:11:45 EDT
Improve the UI to support dark color schemes. Mainly icons (ugly borders), but also for other components like the breadcrumb, some colors (URL color) and the Rich editors.

-- Configuration Details --
Product: Eclipse 1.3.2.20110218-0812 (org.eclipse.epp.package.java.product)
Installed Features:
 org.eclipse.jdt 3.6.2.r362_v20101117-0800-7z8XFW6FLFlmjJcvz03jyeFBLS_F
Comment 1 Dani Megert CLA 2011-04-11 04:28:32 EDT
Color schemes (aka 'Themes') are provided by the Platform.
Comment 2 hooluupog CLA 2013-03-15 22:21:23 EDT
Created attachment 228525 [details]
white console color within dark theme
Comment 3 hooluupog CLA 2013-03-15 22:23:49 EDT
Created attachment 228526 [details]
white row and colum color within dark theme

Currently Color schemes isn't enough to make a consistent and high quality dark theme for juno. Not only the editor area but also all of the eclipse UI should be themable and customizable. E.g, this dark theme(https://github.com/eclipse-color-theme/eclipse-ui-themes) is awsome but
- Console colors don’t fit
- Scrollbar colors don’t fit
- Table head row colors under “Problems” doesn’t fit.
Comment 4 Andrew Clement CLA 2013-05-13 16:54:50 EDT
I'm also interested in this feature. Are there any plans to enable full support for dark themes? Depending on the size of the problem my team and I might be able to help out with a pull request or two if we had a bit of guidance in where to investigate.
Comment 5 Paul Webster CLA 2013-05-14 08:41:23 EDT
We haven't been looking at the dark themes lately, but we welcome any input.  The largest collection I've seen is on http://eclipsecolorthemes.org/

PW
Comment 6 Andrew Clement CLA 2013-05-14 12:15:00 EDT
Hi Paul - those are the themes I was trying out. The problem is that they don't provide the best experience as per the screenshot on comment 3 (and in comment 4).  (I'll say I have been assuming it was eclipse problems rather than theme problems...)

I saw exactly the same thing as hooluupog:

- the scrollbars don't get themed
- some table header rows don't get themed
- the icons have a border that suggests they are expecting a light background

Are the first two known limitations right now, are they feasibly addressable without a mountain of work? The scrollbars thing is particularly annoying.

Are there any plans to address the icons (and maybe upgrade them to retina as part of the process...) - this would be a big job I know but I'd be interested to hear of any future plans to do it.
Comment 7 Paul Webster CLA 2013-05-22 10:35:07 EDT
Bogdan, could you comment on comment #6?

For the icons, is it some of them or all of them?  I thought our icons were 16x16 GIFs or PNGs with transparent backgrounds, so they should show through the background colours (but I don't know for sure).

PW
Comment 8 Bogdan Gheorghe CLA 2013-05-22 17:30:51 EDT
Our icons are GIFs on a transparent background. Unfortunately, a number of them (Run, New Java Class - anything round) - have a few pixels in the corner that are almost white. These are part of the image and not from the background.

In terms of the other questions:

Win32
- Scrollbars, table headers and menus all need custom draw support to be added to SWT as there is no API that can be called to set colors. This is no small task.

GTK
- Menus and Table headers can have colors set on them, but SWT doesn't expose this API since the equivalent functionality isn't available on the Windows and Mac

Mac
- Can't set menu color, toolbar headers or scrollbars. I don't think there is any custom draw support available there.
Comment 9 Bogdan Gheorghe CLA 2013-05-22 17:35:09 EDT
hooluupog:

The console can be styled from CSS by doing something like this:

#org-eclipse-ui-console-ConsoleView Composite {
background-color: #000000
}


Unfortunately, the background color will get hammered as soon as someone writes out to the console. This is because the console preferences (from 3.x) still override the CSS preferences. The right answer is to unify these two preference mechanisms.
Comment 10 Andrew Clement CLA 2013-05-27 14:17:17 EDT
Thanks for that info Bogdan. I guess the icons problem can be fixed with a round of edits to remove those rogue pixels. But what can we really do to address this bigger general problem of dark widgets in eclipse?  If I used an alternative implementation of SWT, is that going to address it? or would limitations in the SWT API probably still give me problems?  I see a couple of JavaFX backed SWT implementations but they are at an early stage and may not be moving forward right now:

Doug's: https://github.com/dschaefer/swt-javafx
Tom's: http://tomsondev.bestsolution.at/2012/06/05/almost-totally-crazy/

And maybe the Bling IDE:

http://www.eclipsecon.org/2013/sessions/experience-bling-gpu-powered-game-ide

any other options?