Bug 341220 - Update the migration guide to notify adopters about the changes to the 'Properties' view regarding post selection events
Summary: Update the migration guide to notify adopters about the changes to the 'Prope...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 RC4   Edit
Assignee: Prakash Rangaraj CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2011-03-29 08:22 EDT by Remy Suen CLA
Modified: 2011-06-03 04:34 EDT (History)
3 users (show)

See Also:

Attachments
Patch v01 (1.94 KB, patch)
2011-05-31 07:21 EDT, Prakash Rangaraj CLA 		no flags Details | Diff
Patch v02 (2.12 KB, patch)
2011-06-01 13:59 EDT, Oleg Besedin CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-03-29 08:22:06 EDT 
We should update the migration guide so that adopters will be notified that an IPostSelectionProvider must forward post selection events or the 'Properties' view may not refresh when the selection has changed.
Comment 1 Oleg Besedin CLA 2011-04-12 11:24:07 EDT 
For the reference, this originated from the bug 339360 .
Comment 2 Prakash Rangaraj CLA 2011-05-31 07:21:33 EDT 
Created attachment 196977 [details]
Patch v01
Comment 3 Prakash Rangaraj CLA 2011-05-31 07:22:07 EDT 
Is this fine or should we provide more detailed information?
Comment 4 Remy Suen CLA 2011-05-31 09:30:35 EDT 
(In reply to comment #2)
> Created attachment 196977 [details]
> Patch v01

This text is of interest to plug-in developers if they wish to ensure that the 'Properties' view is "optimized" when their view has selections that has properties to show.

However, the main underlying problem is that clients that implement IPostSelectionProvider must actually fire post selection events. If they don't forward this event properly then their 'Properties' view may not work. Those that simply implement ISelectionProvider will work as they did before, it is just a problem for those who implement IPSP but does not actually fire post selection events that will be affected by the change in the 'Properties' view's selection handling.
Comment 5 Dani Megert CLA 2011-05-31 09:42:51 EDT 
(In reply to comment #4)
+1.

Minor issues:
- the copyright date is wrong.
- write "view" with lowercase ==> Properties view
Comment 6 Oleg Besedin CLA 2011-06-01 13:59:13 EDT 
Created attachment 197123 [details]
Patch v02
Comment 7 Oleg Besedin CLA 2011-06-01 14:04:09 EDT 
Patch applied to CVS Head.
Comment 8 Dani Megert CLA 2011-06-02 04:12:48 EDT 
The ´ character introduced a CHKPII error. I've fixed that for I20110602-0800.
Comment 9 Oleg Besedin CLA 2011-06-02 09:59:00 EDT 
(In reply to comment #8)
> The ´ character introduced a CHKPII error. I've fixed that for I20110602-0800.

Thank you!
Comment 10 Dani Megert CLA 2011-06-02 11:54:47 EDT 
np. Glad to help! I guess at some point we should set the encoding on the project(s) and check it into CVS.
Comment 11 Dani Megert CLA 2011-06-03 04:34:31 EDT 
Verified in I20110602-1051.