Bug 341114 - 'Consider file contents in comparison' option needs clarification
Summary: 'Consider file contents in comparison' option needs clarification
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M7   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation, polish
Depends on:
Blocks:
 
Reported: 2011-03-28 10:50 EDT by Dani Megert CLA
Modified: 2011-03-29 06:04 EDT (History)
1 user (show)

See Also:
daniel_megert: review+

Attachments
Fix v01 (4.92 KB, patch)
2011-03-28 12:24 EDT, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (39.39 KB, application/octet-stream)
2011-03-28 12:24 EDT, Tomasz Zarna CLA 		no flags Details
Improved fix (2.43 KB, patch)
2011-03-29 05:22 EDT, Dani Megert CLA 		no flags Details | Diff
Improved fix (9.74 KB, patch)
2011-03-29 05:30 EDT, Dani Megert CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-03-28 10:50:18 EDT 
'Consider file contents in comparison' option needs clarification:
- The preference does not work for all comparisons
  ==> need to clarify this, maybe even change the label.
- F1 help says "By default timestamps are used to compare CVS files" but the
  preference is enabled and the help document says something else.
  ==> we should synchronize F1 and doc and not use "By default" or "Usually".
- It seems to matter whether model based comparison is used or not.
- CVS Compare started via History view seems to ignore the preference and always
  use content based compare (see bug 315747 comment 8).

See bug 315747 for all the details.
Comment 1 Tomasz Zarna CLA 2011-03-28 12:24:14 EDT 
Created attachment 192022 [details]
Fix v01

First version, will review again tomorrow morning. I'm done for today.
Comment 2 Tomasz Zarna CLA 2011-03-28 12:24:17 EDT 
Created attachment 192023 [details]
mylyn/context/zip
Comment 3 Dani Megert CLA 2011-03-29 05:22:38 EDT 
Created attachment 192070 [details]
Improved fix
Comment 4 Dani Megert CLA 2011-03-29 05:24:40 EDT 
Tomek, your fix looks good. I've improved it only a little bit:
- Added link to preference page help on the F1 page.
- Removed special F1 help for the first checkbox as this was easy to get and not
  common to have individual F1 help for each widget on the pref page.
Comment 5 Dani Megert CLA 2011-03-29 05:30:53 EDT 
Created attachment 192071 [details]
Improved fix
Comment 6 Tomasz Zarna CLA 2011-03-29 06:04:07 EDT 
Latest fix has been applied to HEAD with a minor change: to be consistent with titles of other CVS pref page docs I removed the "Preferences" Dani added. I left the label in the link untouched. Thanks again!

Available in builds >=I20110329-0800.