Bug 340986 - [review] add facility to remove (Hudson) build server from Builds list
Summary: [review] add facility to remove (Hudson) build server from Builds list
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 0.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.5   Edit
Assignee: maarten meijer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 430729 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-25 13:06 EDT by maarten meijer CLA
Modified: 2014-09-02 12:51 EDT (History)
6 users (show)

See Also:


Attachments
duplicate Hudson servers in list (20.04 KB, image/png)
2011-03-25 13:08 EDT, maarten meijer CLA
no flags Details
network layout causing problem (1.68 MB, image/jpeg)
2011-04-03 05:37 EDT, maarten meijer CLA
no flags Details
Delete Build Server from Builds view UI (55.82 KB, image/png)
2014-03-08 11:14 EST, maarten meijer CLA
no flags Details
Pure plugin.xml patch to allow deleting Build Server from Builds view (1.68 KB, patch)
2014-03-08 11:29 EST, maarten meijer CLA
no flags Details | Diff
mylyn/context/zip (22.07 KB, application/octet-stream)
2014-03-08 11:29 EST, maarten meijer CLA
no flags Details
Submitted extra code change to Gerrit to ask for confirmation with this dialog (14.18 KB, image/png)
2014-05-21 06:16 EDT, maarten meijer CLA
no flags Details
mylyn/context/zip (15.29 KB, application/octet-stream)
2014-09-02 05:52 EDT, maarten meijer CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description maarten meijer CLA 2011-03-25 13:06:56 EDT
I can easily add a build server and the discovery works, but I now have a duplicate on localhost and my Bonjour via 2nd port.
I would like to remove one of them, but no delete popup, key or whatever.

PS Looks easy, so consider assigning to me to resolve ;-)
Comment 1 maarten meijer CLA 2011-03-25 13:08:11 EDT
Created attachment 191925 [details]
duplicate Hudson servers in list

Cannot delete one of them
Comment 2 Steffen Pingel CLA 2011-04-01 16:40:43 EDT
Have you tried deleting from the Team Repositories view?
Comment 3 maarten meijer CLA 2011-04-01 17:54:57 EDT
Team Repos is almost same as Task Repos, so I didn't even think of that one.
Still seems logical that you can remove stuff from build viiew as well, just as tasks and queries from Task List...
Comment 4 Torkild Resheim CLA 2011-04-02 17:52:40 EDT
Maybe there is another problem here. I don't think the automatic discovery should allow a server to be added if it has already been configured. Which one came first?
Comment 5 maarten meijer CLA 2011-04-02 17:54:38 EDT
localhost was manual, second one on bonjour came automatic
Comment 6 Torkild Resheim CLA 2011-04-02 18:02:45 EDT
That was prompt! Thanks Maarten. Do they have different URLs? The discovery mechanism relies on the address that Jenkins/Hudson itself announces. Which in some cases will cause trouble as the service may be accessible through different URLs. But we should probably do some effort trying to figure that out.
Comment 7 maarten meijer CLA 2011-04-03 05:37:27 EDT
Created attachment 192423 [details]
network layout causing problem

I think relying on name or IP is not enough to prevent duplicates from occuring. Perhaps a hash of all jobs running may also be required to spot duplicates. But even then, the may be mirrors :-(
Doesn't Hudson itself generate and provide some sort of unique identifier on startup?
Maybe time for a Hudson/Jenkins issue to resolve this.
Comment 8 maarten meijer CLA 2011-04-03 05:39:03 EDT
(In reply to comment #6)
> That was prompt! Thanks Maarten. Do they have different URLs?
http://localhost:9090/ and http://quadbox.local:9090/ are the URL's
Comment 9 Torkild Resheim CLA 2011-04-03 14:52:28 EDT
Thanks Maarten. At the time Hudson did not provide any useful identifier besides the URL. I also think there should be some sort of unique identifier. I've added bug 341725 to track this particular issue.
Comment 10 Steffen Pingel CLA 2011-07-21 18:53:44 EDT
I think we should consider a delete action for the Builds view as I have heard from others asking for that feature as well.
Comment 11 Eike Stepper CLA 2014-03-02 04:04:41 EST
Hi, I just spent 5 minutes to find out how to remove servers from the builds view. Having a context menu action in the builds view would make total sense to me ;-)
Comment 12 maarten meijer CLA 2014-03-08 11:14:25 EST
Created attachment 240686 [details]
Delete Build Server from Builds view UI

With this patch it become possible to delete a Build Server directly from the Buils view. You don't have to open the Team Repositories view and delete from there which is virtually unfindable.
Comment 13 maarten meijer CLA 2014-03-08 11:29:33 EST
Created attachment 240687 [details]
Pure plugin.xml patch to allow deleting Build Server from Builds view

All code is present in the org.eclipse.mylyn.builds.ui and only needs to be connected with two extra items in plugin.xml
Comment 14 maarten meijer CLA 2014-03-08 11:29:36 EST
Created attachment 240688 [details]
mylyn/context/zip
Comment 15 maarten meijer CLA 2014-03-08 11:30:17 EST
please assign to me and review patch
Comment 16 Steffen Pingel CLA 2014-03-12 05:59:04 EDT
Thanks for the patch! Can you please push it to Gerrit? We can then do a review and consider it for 3.12.
Comment 17 maarten meijer CLA 2014-03-12 11:24:54 EDT
Done:
23257: 340986: [patch] add facility to remove (Hudson) build server from Builds list [I3fb05327]
https://git.eclipse.org/r/#/c/23257/
Comment 18 Steffen Pingel CLA 2014-03-20 06:23:21 EDT
*** Bug 430729 has been marked as a duplicate of this bug. ***
Comment 19 maarten meijer CLA 2014-04-13 02:39:49 EDT
Hi Steffen,

I have created a patch, submitted to Gerrit and received some comments, but I'm at a lost to find oit how to proceed now.

23257: 340986: [patch] add facility to remove (Hudson) build server from Builds list [I3fb05327]
https://git.eclipse.org/r/#/c/23257/

How can I change commit message and leave rest unaltered?
Comment 20 Sam Davis CLA 2014-04-24 19:57:18 EDT
You would need to amend your commit, altering the message, and push again.
Comment 21 maarten meijer CLA 2014-04-26 09:10:16 EDT
I think I succeeded in amending the commit message by using the same change ID.
Amending a commit example should be added to http://www.eclipse.org/community/eclipse_newsletter/2013/september/article4.php
Comment 22 Tomasz Zarna CLA 2014-05-02 16:48:27 EDT
(In reply to maarten meijer from comment #21)
> I think I succeeded in amending the commit message by using the same change
> ID.

I don't see a new patch set on that review, so maybe you didn't push the new version. Anyway, if the only thing you want to amend is the commit message, you can do it using the web UI. You just need to be logged in.
Comment 23 maarten meijer CLA 2014-05-21 06:16:42 EDT
Created attachment 243330 [details]
Submitted extra code change to Gerrit to ask for confirmation with this dialog

I notice that the builds plug-in is not (yet) internationalized, so I simply put parameter in String embedded in code.
Comment 24 maarten meijer CLA 2014-05-21 16:26:10 EDT
Abandoning change, Gerrit workflow gives too much grief
Comment 25 Sam Davis CLA 2014-05-29 16:24:12 EDT
New review at https://git.eclipse.org/r/#/c/27518/
Comment 26 maarten meijer CLA 2014-09-02 05:52:11 EDT
Merged into Master
Comment 27 maarten meijer CLA 2014-09-02 05:52:17 EDT
Created attachment 246609 [details]
mylyn/context/zip