Bug 340889 - [CSS] Platform color scheme does not work together with SWT color constants
Summary: [CSS] Platform color scheme does not work together with SWT color constants
Status: CLOSED DUPLICATE of bug 564380
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 major with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
: 356842 426753 435846 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-24 13:23 EDT by Andrew Niefer CLA
Modified: 2020-11-11 07:38 EST (History)
12 users (show)

See Also:


Attachments
Screenshot (5.87 KB, image/jpeg)
2011-03-24 13:23 EDT, Andrew Niefer CLA
no flags Details
Possible fix reverting the workaround for bug #39661 (840 bytes, patch)
2012-04-16 09:22 EDT, Anton G. CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2011-03-24 13:23:13 EDT
Created attachment 191845 [details]
Screenshot

See attached screenshot,
The JUnit view shows results like:
Runs: 0/0  Errors: 0 Failures: 0

The background color for these numbers is the grey toolbar color from Eclipse 3.x.

Under Eclipse 4.1, the view's background is white and the grey background used here doesn't look good anymore.

If possible, the view should use a background color matching the space around it.
Comment 1 Dani Megert CLA 2011-03-25 03:08:56 EDT
The default background got changed which affects all views. It's not feasible that the hole world (speak each view) adapts to this when running on the 4.x platform. There needs to be a better/general solution that fixes this.
Comment 2 Dani Megert CLA 2011-03-25 03:12:55 EDT
See also bug 320901, bug 332452 and bug 320238.
Comment 3 Markus Keller CLA 2011-09-07 08:39:10 EDT
*** Bug 356842 has been marked as a duplicate of this bug. ***
Comment 4 Anton G. CLA 2012-04-16 09:22:03 EDT
Created attachment 214050 [details]
Possible fix reverting the workaround for bug #39661

I am not sure that it is acceptable fix, but it works properly on Linux and Windows platforms.
Comment 5 Dani Megert CLA 2012-04-17 06:18:51 EDT
(In reply to comment #4)
> Created attachment 214050 [details] [diff]
> Possible fix reverting the workaround for bug #39661
> 
> I am not sure that it is acceptable fix, but it works properly on Linux and
> Windows platforms.

Sure it works on those platforms ;-). The workaround was  made for Mac and the corresponding SWT bug 71765 is still not fixed.

The real bug is that Platform UI uses a different color for the background than SWT reports when calling
    aDisplay.getSystemColor(SWT.COLOR_WIDGET_BACKGROUND));

All clients using that API are currently broken as they don't get the "real" widget background color that's used by Platform UI.

Other SWT color constants also collide with the new color model, e.g.
   SWT.COLOR_WIDGET_HIGHLIGHT_SHADOW
Because that shadow is white, the JUnit's progress field looks bad / has no border at the bottom.
Comment 6 Dani Megert CLA 2014-01-28 02:52:34 EST
*** Bug 426753 has been marked as a duplicate of this bug. ***
Comment 7 Daniel Rolka CLA 2014-05-27 11:04:21 EDT
*** Bug 435846 has been marked as a duplicate of this bug. ***
Comment 8 Lars Vogel CLA 2016-04-20 12:09:14 EDT
Mass move to 4.7 as M7 is approaching. Please move back in case you are planning to fix it for Neon.
Comment 9 Dani Megert CLA 2018-05-24 13:01:28 EDT
Moving target milestone to 4.9 for all bugs that are major or above.
Comment 10 Eclipse Genie CLA 2020-11-11 02:33:10 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 11 Lars Vogel CLA 2020-11-11 04:24:01 EST
Mickael, didn't you fix that one?
Comment 12 Mickael Istria CLA 2020-11-11 07:38:59 EST
It's indeed a dup of 564380; and a new theme is available, relying on system colors.

*** This bug has been marked as a duplicate of bug 564380 ***