Bug 340745 - Polish the fix for bug 339197
Summary: Polish the fix for bug 339197
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.7 M7   Edit
Assignee: Szymon Ptaszkiewicz CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 339197
Blocks:
  Show dependency tree
 
Reported: 2011-03-23 07:52 EDT by Szymon Ptaszkiewicz CLA
Modified: 2011-03-23 12:04 EDT (History)
0 users

See Also:
Szymon.Brandys: review+

Attachments
Patch v.0.1 (1.35 KB, patch)
2011-03-23 07:52 EDT, Szymon Ptaszkiewicz CLA 		no flags Details | Diff
Patch v.0.2 (2.13 KB, patch)
2011-03-23 09:00 EDT, Szymon Ptaszkiewicz CLA 		Szymon.Brandys: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Ptaszkiewicz CLA 2011-03-23 07:52:59 EDT 
Created attachment 191742 [details]
Patch v.0.1

Fix for bug 339197 added new lines in ProjectPreference.save(). One of them contains condition that is always true so there is no point to check this condition.
Comment 1 Szymon Ptaszkiewicz CLA 2011-03-23 08:08:16 EDT 
I found also another thing that should be changed there. The patch will follow.
Comment 2 Szymon Ptaszkiewicz CLA 2011-03-23 09:00:46 EDT 
Created attachment 191745 [details]
Patch v.0.2

Derived rule is currently null but in case it may change in the future we should also add it to the combined rule.
Comment 3 Szymon Brandys CLA 2011-03-23 12:04:08 EDT 
Fixed.