Bug 34050 - [Viewers] Configs dialog does not handle missing icon for type
Summary: [Viewers] Configs dialog does not handle missing icon for type
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-06 23:38 EST by Nick Edgar CLA
Modified: 2007-06-19 15:20 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2003-03-06 23:38:33 EST 
build I20030304

Was trying the example in bug 32740, which defines a launch config type but 
does not specify an icon.
The tree in the launch configs dialog has a blank space where the icon should 
go, for the type and any created configs.

SWT widgets on Windows don't handle null images very well.

Suggest using the following pattern:
if (treeItem.getImage() != image)
  treeItem.setImage(image)
Comment 1 Darin Wright CLA 2003-03-18 22:00:44 EST 
Deferred
Comment 2 Darin Wright CLA 2003-05-28 14:52:08 EDT 
Open for 3.0
Comment 3 Darin Wright CLA 2003-12-10 21:57:57 EST 
Nick (sorry, old bug),

The tree viewer in this case is simply a tree viewer with a standard 
ILabelProvider. The label provider API allows null to be returned from "getImage
(...)". Although the tree item has no image (and other nodes in the tree do), 
there is little we can do about this - we do not make the call to set the image 
on the tree item, the tree viewer does that.

We do not intend to provide a default image for launch config types.
Comment 4 Nick Edgar CLA 2006-03-15 11:47:39 EST 
Reassigning bugs in component areas that are changing ownership.
Comment 5 Boris Bokowski CLA 2007-06-19 15:20:36 EDT 
No plans to work on this.