Community
Participate
Working Groups
Some repositories define many flags which can make the attributes section very long. It's also not easy to determine which flags are actually set. To improve I suggest that flags are moved to a sub-section of Attributes named "Flags" that is collapsed by default. The section client are should show all configured flags similar to how the product / component is shown in the title of th eAttributes section.
Let's do this for 3.6, should be straight forward.
Created attachment 191078 [details] patch V1 Here is what I commit to HEAD. The infoOverlayText on the right has a Tooltip with Details. Steffen, please review!
Created attachment 191079 [details] mylyn/context/zip
It doesn't seem to work for me. I get a section with a label that says "0 unused flags" but flags still show under attributes. It shouldn't show if there are no attributes and I would expect that we need to migrate task data?
(In reply to comment #4) > It doesn't seem to work for me. I get a section with a label that says "0 unused > flags" but flags still show under attributes. It shouldn't show if there are no > attributes and I would expect that we need to migrate task data? Yes we have to migrate the TaskData! I change the BugzillaFagMapper to no longer use TaskAttribute.KIND_DEFAULT (which is shown under Attributes) now BugzillaAttribute.KIND_FLAG is used. Hope that I can do a fix for this today.
Fix is now in HEAD, please test. Sorry that I not include the migrate in my first patch.
Created attachment 191161 [details] mylyn/context/zip
Thanks. It seems to work now for bugs.eclipse.org. I still get an empty section though for bugs that do not have flags (e.g. https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4397). The CQ bugs are kind of odd anyways since I do see flags in the web interface but it's an older Bugzilla (3.0.1).
Some suggestion for the label: * Left align it with the section header (use two " " spaces to separate it) * Change the format to: 7 Flags (2 set)
I commit the changes requested in comment #8 and comment #9. * BugzillaFlagMapper.applyTo only set the kind for Bugzilla >= 3.2 so I had to change the migrate to. * If no Flags exist in the TaskData we do not include the BugzillaFlagPart in the Editor. * To add Actions to the ExpandableComposite define fillToolBar in BugzillaFlagPart.
Created attachment 191256 [details] mylyn/context/zip
This looks great. Only minor nit that I have left, is that we should remove the text in parenthesis "(0 set)" if there are no flags set.
Created attachment 193519 [details] patch V4 committed patch
Created attachment 193520 [details] mylyn/context/zip
Think we are done here!
Created attachment 195675 [details] screenshot
