Bug 339430 - Delta pack for Eclipse 4.2
Summary: Delta pack for Eclipse 4.2
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 4.2 RC1   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 355430
  Show dependency tree
 
Reported: 2011-03-09 16:21 EST by Kit Lo CLA
Modified: 2012-05-10 02:08 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kit Lo CLA 2011-03-09 16:21:52 EST
Any plan to produce the delta pack for Eclipse 4.1 build?
Comment 1 Kim Moir CLA 2011-03-10 07:04:51 EST
Kit, do you have a consumer requesting it?  You're probably aware that 4.1 doesn't ship on as many platforms as 3.7 so if it was created, it would contain fewer fragments.
Comment 2 Kit Lo CLA 2011-03-10 07:26:49 EST
I need that to build language packs for different platforms. I'm aware that 4.1 is supported on fewer platforms. As long as it's the complete set for supported platforms for 4.1, this delta pack is still useful. Thanks!
Comment 3 Andrew Niefer CLA 2011-03-11 16:06:00 EST
I guess the first question is if 4.1 contains any platform specific fragments on in 3.7.

If not, then the 3.7 deltapack from the 3.7 Build that the 4.1SDK was built against would work just fine.
Comment 4 Andrew Niefer CLA 2011-03-11 16:06:20 EST
(In reply to comment #3)
> I guess the first question is if 4.1 contains any platform specific fragments
> on in 3.7.
 * not in 3.7
Comment 5 Andrew Niefer CLA 2011-03-11 16:15:17 EST
There does appear to be at least one new fragment:
org.eclipse.e4.ui.workbench.renderers.swt.cocoa
Comment 6 John Arthorne CLA 2012-04-20 16:13:01 EDT
The delta pack is now being generated for 4.2 integration builds, but it looks busted. At least SWT is missing..
Comment 7 David Williams CLA 2012-04-27 15:52:08 EDT
Just to document some observations, the 3.8 M6 delta pack had one feature: 

org.eclipse.equinox.executable_3.6.0.v20120305-1541-7P7OFvNFLWUl7Dqyq6OBBmS

the latest 4.2 I build's delta pack has one feature, 

org.eclipse.equinox.executable_3.6.0.v20120426-1529-7P7OFvNFLWUl7UmDUz0O8_a2

They each have 138 files or directories, so assuming that's ok. 

The following is the list of missing plugins from the recent I builds (besides "swt", there's "org.eclipse.ui.cocoa*" and "org.eclipse.update.core.*").

org.eclipse.swt.cocoa.macosx_3.8.0.v3823a.jar
org.eclipse.swt.cocoa.macosx.source_3.8.0.v3823a.jar
org.eclipse.swt.cocoa.macosx.x86_64_3.8.0.v3823a.jar
org.eclipse.swt.cocoa.macosx.x86_64.source_3.8.0.v3823a.jar
org.eclipse.swt.gtk.aix.ppc_3.8.0.v3823a.jar
org.eclipse.swt.gtk.aix.ppc64_3.8.0.v3823a.jar
org.eclipse.swt.gtk.aix.ppc64.source_3.8.0.v3823a.jar
org.eclipse.swt.gtk.aix.ppc.source_3.8.0.v3823a.jar
org.eclipse.swt.gtk.hpux.ia64_32_3.8.0.v3823a.jar
org.eclipse.swt.gtk.hpux.ia64_32.source_3.8.0.v3823a.jar
org.eclipse.swt.gtk.linux.ppc64_3.8.0.v3823a.jar
org.eclipse.swt.gtk.linux.ppc64.source_3.8.0.v3823a.jar
org.eclipse.swt.gtk.linux.s390_3.8.0.v3823a.jar
org.eclipse.swt.gtk.linux.s390.source_3.8.0.v3823a.jar
org.eclipse.swt.gtk.linux.s390x_3.8.0.v3823a.jar
org.eclipse.swt.gtk.linux.s390x.source_3.8.0.v3823a.jar
org.eclipse.swt.gtk.linux.x86_3.8.0.v3823a.jar
org.eclipse.swt.gtk.linux.x86_64_3.8.0.v3823a.jar
org.eclipse.swt.gtk.linux.x86_64.source_3.8.0.v3823a.jar
org.eclipse.swt.gtk.linux.x86.source_3.8.0.v3823a.jar
org.eclipse.swt.gtk.solaris.sparc_3.8.0.v3823a.jar
org.eclipse.swt.gtk.solaris.sparc.source_3.8.0.v3823a.jar
org.eclipse.swt.gtk.solaris.x86_3.8.0.v3823a.jar
org.eclipse.swt.gtk.solaris.x86.source_3.8.0.v3823a.jar
org.eclipse.swt.win32.win32.x86_3.8.0.v3823a.jar
org.eclipse.swt.win32.win32.x86_64_3.8.0.v3823a.jar
org.eclipse.swt.win32.win32.x86_64.source_3.8.0.v3823a.jar
org.eclipse.swt.win32.win32.x86.source_3.8.0.v3823a.jar

org.eclipse.ui.cocoa_1.1.0.v20111007-1312.jar
org.eclipse.ui.cocoa.source_1.1.0.v20111007-1312.jar

org.eclipse.update.core.linux_3.2.200.v20100512.jar
org.eclipse.update.core.linux.source_3.2.200.v20100512.jar
org.eclipse.update.core.win32_3.2.200.v20100512.jar
org.eclipse.update.core.win32.source_3.2.200.v20100512.jar
Comment 8 David Williams CLA 2012-05-08 12:58:18 EDT
I'm going to add some "echoproperties" and "verbose" settings to the delta-pack build.xml file. 

Not sure what's going on ... but I don't see anything obviously "swt related" in there. 

Perhaps the echos will help. Perhaps some directory is "missing" or its location has changed with other chagnes?
Comment 9 David Williams CLA 2012-05-09 01:49:30 EDT
To update some status, I noticed the 3.8 M7 build had the right number of plugins (76, same as 3.8 M6) but 4.2 M7 was still missing swt (had only 42 bundle). 

So ... I'm adding some more debug statements and "failonerror=true" attributes, in case there's something going on that is not obvious. 

In brief, this is supposed to be basically a packaging step, mirroring a set of things from the repo we've built to a "tempfolder" and then removing some, then creating a p2 runnable in a "temp 2 folder" and then "assemblying" that runnable into the zip as desired. 

So, looking "after the build", the repo has the right swt stuff in it, but the tempfolder does not, either not mirrored or later deleted (there are some funky removal stuff going on in there :) 

Since the builder is the same for the two streams, I don't think its difference in the builder, per se, though there could be differences in timing or perhaps order when things run. I checked though, and I think the remaining (substantial) parallel segments only have to do with packaging, not the initial building. 

But, now that I've just looked again there is a difference in the rcp feature between the master version and R4_HEAD version. It appears a the swt plugins were "moved out"? I assume into the org.eclipse.e4.rcp feature?  I'd think it'd be pulled in automatically ... but ... perhaps not, or perhaps with the oddities of that task. By oddities, I mean it "mirrors" features such as 

id="org.eclipse.platform.feature.group"
id="org.eclipse.platform.source.feature.group"
id="org.eclipse.rcp.feature.group"
id="org.eclipse.rcp.source.feature.group"
id="org.eclipse.jdt.feature.group"
 id="org.eclipse.jdt.source.feature.group"
id="org.eclipse.equinox.executable"

And then turns around and immediately p2.removes 
several of them: 

<iu id="org.eclipse.jdt.feature" />
<iu id="org.eclipse.jdt.source.feature" />
<iu id="org.eclipse.platform.feature" />
<iu id="org.eclipse.platform.source.feature" />
<iu id="org.eclipse.rcp.feature" />
<iu id="org.eclipse.rcp.source.feature" />

I don't see where the org.eclipse.e4.rcp feature is right off, but assume that's where the swt bundles moved to?
Comment 10 David Williams CLA 2012-05-09 02:11:43 EDT
I'm trying a test build now, with adding  an IU to mirror
id="org.eclipse.e4.rcp.feature.group"

Then explicitly remove
 id="org.eclipse.e4.rcp.feature.jar"

I suspect there may end up being a few more things I have to explicitly remove, but will just find out experientially. 

Not sure if this will end up need to be a stream specific file, or if the 3.8 build will "over look" the fact that the IU and jar do not exist there.
Comment 11 David Williams CLA 2012-05-09 08:41:09 EDT
adding the e4.rcp feature helped, though I'll also need the e4.rcp source feature. With that, it looks like we will still be 4 short, my guess would be: 

org.eclipse.update.core.linux_3.2.200.v20100512.jar
org.eclipse.update.core.linux.source_3.2.200.v20100512.jar
org.eclipse.update.core.win32_3.2.200.v20100512.jar
org.eclipse.update.core.win32.source_3.2.200.v20100512.jar

Where might those "live" these days? Have they been removed from 4.2? I do not see them in the content.jar/xml.
Comment 12 John Arthorne CLA 2012-05-09 08:56:26 EDT
(In reply to comment #11)
> adding the e4.rcp feature helped, though I'll also need the e4.rcp source
> feature. 

Yes SWT was moved to the e4.rcp feature to make it functional "standalone".

> 
> org.eclipse.update.core.linux_3.2.200.v20100512.jar
> org.eclipse.update.core.linux.source_3.2.200.v20100512.jar
> org.eclipse.update.core.win32_3.2.200.v20100512.jar
> org.eclipse.update.core.win32.source_3.2.200.v20100512.jar
> 
> Where might those "live" these days? Have they been removed from 4.2? I do not
> see them in the content.jar/xml.

Update core was removed from platform feature in 4.2. They should not appear in the 4.2 delta pack.
Comment 13 David Williams CLA 2012-05-09 13:05:00 EDT
(In reply to comment #12)
> (In reply to comment #11)
> > adding the e4.rcp feature helped, though I'll also need the e4.rcp source

> 
> Update core was removed from platform feature in 4.2. They should not appear in
> the 4.2 delta pack.

I am so glad to hear that :) 

With adding source, the numbers of plugin now matches expectations (72, compared to the 76 in 3.8). So, I will blindly assume they are the correct ones. 

Currently testing if 3.8 will work as is, or if we need to have another "stream specific" configuration file (which is no big deal). After determining that, I'm going to try a test run without the "jdt" and "platform" stuff in the list ... I think not needed and adds to confusion (and, maybe a few minutes of wasted time) ... perhaps they were needed many releases ago?
Comment 14 John Arthorne CLA 2012-05-09 13:26:27 EDT
As mentioned in comment #5, I would expect one new fragment in 4.2:

org.eclipse.e4.ui.workbench.renderers.swt.cocoa

Unless you are specifically excluding this, I was hoping this would just be picked up by virtue of its inclusion in org.eclipse.e4.rcp, which is included in org.eclipse.rcp. Apparently not though?
Comment 15 David Williams CLA 2012-05-09 14:00:11 EDT
(In reply to comment #14)
> As mentioned in comment #5, I would expect one new fragment in 4.2:
> 
> org.eclipse.e4.ui.workbench.renderers.swt.cocoa
> 
> Unless you are specifically excluding this, I was hoping this would just be
> picked up by virtue of its inclusion in org.eclipse.e4.rcp, which is included
> in org.eclipse.rcp. Apparently not though?

Ok, made me look. :) 

It does have those, such as: 

org.eclipse.e4.ui.workbench.renderers.swt.cocoa_0.10.0.v20120503-1731.jar
org.eclipse.e4.ui.workbench.renderers.swt.cocoa.source_0.10.0.v20120503-1731.jar

So, besides the 4 related update bundles, 3.8 also has (that 4.2 does not): 

org.eclipse.ui.cocoa_1.1.0.v20120502-1545.jar
org.eclipse.ui.cocoa.source_1.1.0.v20120502-1545.jar

Sound right? Or is "org.elcipse.ui.cocoa" missing from 4.2? It doesn't seem mentioned in the 4.2 content.jar/xml.
Comment 16 Paul Webster CLA 2012-05-09 15:11:17 EDT
(In reply to comment #15)
> So, besides the 4 related update bundles, 3.8 also has (that 4.2 does not): 
> 
> org.eclipse.ui.cocoa_1.1.0.v20120502-1545.jar
> org.eclipse.ui.cocoa.source_1.1.0.v20120502-1545.jar
> 
> Sound right? Or is "org.elcipse.ui.cocoa" missing from 4.2? It doesn't seem
> mentioned in the 4.2 content.jar/xml.

correct o.e.ui.cocoa is a 3.8 fragment only.

PW
Comment 17 David Williams CLA 2012-05-09 15:56:10 EDT
Thanks Paul, for confirming. 

In other news, this will have to be "stream specific" file, which I've documented in the delta-pack folder. (i.e. the build file used in eclipse builder is actually "overlayed" at the time of the build). 

One more tidbit: JDT is required ... guess if I'd looked closer, it seems it is what is pulling in 

org.eclipse.jdt.launching.macosx_3.2.100.v20120426-2002.jar
org.eclipse.jdt.launching.macosx.source_3.2.100.v20120426-2002.jar
org.eclipse.jdt.launching.ui.macosx_1.0.100.v20120412-1617.jar
org.eclipse.jdt.launching.ui.macosx.source_1.0.100.v20120412-1617.jar

I've so much to learn :) [like, why those are unique to Mac's, and why needed as part of _RCP_ delta pack. ]
Comment 18 David Williams CLA 2012-05-10 02:03:11 EDT
So, build is fixed, the stream-sensitive parts are in place.
Comment 19 David Williams CLA 2012-05-10 02:08:45 EDT
I confirmed going through a normal I build all turns out ok (had just been "test builds) initially. 

The 38 build from I20120509-2100 matches the 3.8 M6 list of plugins (and the one feature). 

The 4.2 build from I20120509-1900 matches the 3.8 with the differences noted above, 6 removed, 2 added, so 4.2 has 4 less bundles in it. 

(The totals are 75 and 71, btw, not 76 and 72 as reported in some comments above ... I think some of the numbers above were computed 
using ll | wc -l 
which counts the ".." entry, also, or something.