Bug 33917 - [Properties View] "Editable" resource property non-NLS
Summary: [Properties View] "Editable" resource property non-NLS
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.0 M2   Edit
Assignee: Lynne Kues CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-05 16:56 EST by Knut Radloff CLA
Modified: 2003-06-16 17:25 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Knut Radloff CLA 2003-03-05 16:56:29 EST
 
Comment 1 Knut Radloff CLA 2003-03-05 17:04:50 EST
[sorry for the spam, accidentally hit enter]

build 20030304

ResourcePropertySource.getPropertyValue returns hard coded "false"/"true" for 
the "editable" property.
What is "false" to us may be "falsch" to someone else. E.g., the German version 
of MS Excel translates "true" and "false". I don't personally think that is the 
right way to do it but some products may choose to translate these.
If we decide the values should remain non-NLS we should at least use 
String.valueOf(!element.isReadOnly()). If we decide to make them translateable 
we should also change the "derived" and "linked" properties.

CCing the NLS police for comment.
Comment 2 Tod Creasey CLA 2003-03-05 17:12:30 EST
We should display it to the user in the NLed format - whether or not it is 
that way internally doesn't matter - just be careful of code that might match 
on the word if the word might change.
Comment 3 Knut Radloff CLA 2003-03-06 10:31:07 EST
In this case we display the property in the properties view so we should change 
it.
Comment 4 Lynne Kues CLA 2003-06-16 17:25:07 EDT
In Build > 20030616