334445 – date bins for next week should indicate the day of the week

Bug 334445 - date bins for next week should indicate the day of the week

Summary: date bins for next week should indicate the day of the week

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Mylyn (show other bugs)
Version:	unspecified
Hardware:	PC Windows 7

Importance:	P3 enhancement (vote)
Target Milestone:	3.5
Assignee:	Sam Davis
QA Contact:

URL:
Whiteboard:
Keywords:	contributed

Depends on:
Blocks:

Reported:	2011-01-14 19:24 EST by Sam Davis
Modified:	2011-02-17 18:56 EST (History)
CC List:	1 user (show)

See Also:

Attachments
patch (3.48 KB, patch) 2011-01-24 21:35 EST, Sam Davis	no flags	Details \| Diff
mylyn/context/zip (115.11 KB, application/octet-stream) 2011-01-24 21:35 EST, Sam Davis	no flags	Details
screenshot (8.83 KB, image/png) 2011-01-29 20:38 EST, Steffen Pingel	no flags	Details
patch with externalized pattern (5.32 KB, patch) 2011-02-01 13:38 EST, Sam Davis	steffen.pingel: iplog+	Details \| Diff
Reformat dates and tooltips (5.46 KB, patch) 2011-02-17 17:56 EST, Sam Davis	steffen.pingel: iplog+	Details \| Diff
mylyn/context/zip (136.19 KB, application/octet-stream) 2011-02-17 17:56 EST, Sam Davis	no flags	Details
screenshot (8.33 KB, image/png) 2011-02-17 18:34 EST, Steffen Pingel	no flags	Details
screenshot with week start not set to Wednesday! (6.92 KB, image/png) 2011-02-17 18:52 EST, Sam Davis	no flags	Details
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sam Davis

2011-01-14 19:24:42 EST

Date bins for next week should indicate the day of the week. e.g. Jan 18, 2011 (Tuesday)

Comment 1 Steffen Pingel

2011-01-14 20:52:42 EST

+1 I have wanted that for a while.

Comment 2 Sam Davis

2011-01-24 21:35:16 EST

Created attachment 187488 [details]
patch

Steffen, here's a patch. I went with "date - DayOfWeek" as the format as I think it looks better in the tooltip.

Comment 3 Sam Davis

2011-01-24 21:35:18 EST

Created attachment 187489 [details]
mylyn/context/zip

Comment 4 Steffen Pingel

2011-01-29 20:38:24 EST

Created attachment 187914 [details]
screenshot

Comment 5 Steffen Pingel

2011-01-29 21:53:35 EST

Thanks. That looks good. Only one minor nit: Please use NLS.bind() in the constructor of ScheduledTaskContainer and externalize the pattern used to construct the label. I'll apply if you attach an updated patch.

Comment 6 Sam Davis

2011-02-01 13:38:54 EST

Created attachment 188070 [details]
patch with externalized pattern

Comment 7 Steffen Pingel

2011-02-01 19:39:00 EST

Patch applied to head!

Comment 8 Steffen Pingel

2011-02-03 16:23:30 EST

Suggestion from UI review:
* Change labels to "Next Monday - 2-Feb-2011"

Comment 9 Sam Davis

2011-02-03 16:35:38 EST

I suggest that we also change the tooltip to show a long form of the date. Currently the tooltip says things like "Feb 10, 2011 - Thursday [February 10, 2011]" which, if we change the labels as suggested, will become "Next Thursday - Feb 10, 2011 [February 10, 2011]". I suggest changing the tooltip to "Next Thursday - February 10, 2011" so it will be almost exactly the same as what appears in the task list, only the date will be in long format.

Comment 10 Steffen Pingel

2011-02-03 16:56:50 EST

+1 for changing the tooltip as proposed.

Comment 11 Sam Davis

2011-02-17 17:56:20 EST

Created attachment 189239 [details]
Reformat dates and tooltips

Steffen, here's a patch.

Comment 12 Sam Davis

2011-02-17 17:56:23 EST

Created attachment 189240 [details]
mylyn/context/zip

Comment 13 Steffen Pingel

2011-02-17 18:34:48 EST

Created attachment 189243 [details]
screenshot

Comment 14 Steffen Pingel

2011-02-17 18:36:23 EST

Thanks Sam! I have applied the patch but ended up removing the date from the scheduled presentation since it looked very crowded. Let's see how this works out and we can always consider adding it back if there is demand for it.

Comment 15 Sam Davis

2011-02-17 18:52:46 EST

Created attachment 189245 [details]
screenshot with week start not set to Wednesday!