Community
Participate
Working Groups
build I20030221 - Run the Readme example's new Readme File wizard - the "Advanced >>" button appears before additional options added by this subclass (e.g. "Automatic sample section generation", "Open file for editing when done") - click Advanced - the linking UI appearas after the additional options The Advanced button and linking UI should appear after all other options.
Defer
A bad side effect is that when I collapse the Advanced section it is not always hidden. For example in WSAD when I click Advanced in the New GEF Example wizard and then click again to hide the expanded Advanced section parts of the Advanced section are still visible. Also, the first page of the GEF example wizard is initially sized too tall. It appears that the (invisible) Advanced section is included in the page measurement. See also bug 37028. Should consider a fix for the Advanced section cheese for 2.1.1
I think it may be easier to make sure the advanced section expands below the advanced button and leave the group below the file name field. We have no control over the page creation process. We create our page widgets in createControl which is part of IDialogPage. Subclasses do the same and this is the only place for us to do it. There is no later place where we could create the advanced group. From a user point of view it may actually be better to make sure the advanced section always is below the file name field. Otherwise the dialog flow changes based on what widgets subclasses insert between the file name field and the advanced section.
The behaviour described in comment #2 does sound bogus. Please investigate the fix proposed in comment #3 for 2.1.1 so we can evaluate the risk.
Created attachment 4787 [details] CreateLinkedResourceGroup.java Patch maintains settings when widgets are disposed and recreated
Created attachment 4788 [details] WizardNewFileCreationPage.java
Created attachment 4789 [details] WizardNewFolderMainPage.java
The attached three files implement the proposed fix. The linked resource composite now shares a parent with the Advanced button. The linked resource composite is disposed when the advanced section is collapsed and recreated whenever the Advanced section is expanded. This fixes the cheese problem I observed in the WSAD GEF example creation wizard. The fix is fairly low risk. I believe we should release it for 2.1.1. Nick?
Something weird is going on with Bugzilla attachments. The attached files duplicate the class. You will have to edit them when you import them. I notified the webmaster.
Agree with Knut that the risk is low. The proposed changes are localized and minor.
Tod, could you please review the changes as well?
This still creates the added content underneath the advanced button though so is this really any better than what we have right now? I still get the readme stuff under the advanced button. Having said that I think the only solution is to make the control for these pages the area above the Advanced button and I am concerned about a subtle implications this might have. I don't know that this is worth putting into 2.1.1 as it is not much of an improvement.
The real problem is that the advanced section widgets are separated from the button when a subclass ads to the page. Like I wrote in comment #3, I would argue that the Advanced section should always appear at the same place, regardless of what subclasses add to the wizard page. Also, if we don't fix this WSAD and possibly other apps will have cheese. See the attached screen shot. The time span until 3.0 is too long to wait with a fix.
Created attachment 4841 [details] screenshot of GEF example wizard Note that the Advanced section is collapsed, yet part of it is visible. The fix addresses this by actually destroying the advanced widgets instead of just hiding them and putting them in one composite together with the advanced button.
Made minor layout changes to the attached files and released in HEAD and 2_1_maintenance.
Verified fixed in 2_1_maintenance build 20030602
